Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mono 6.4.0 #1640

Merged
merged 6 commits into from Oct 28, 2019
Merged

Use mono 6.4.0 #1640

merged 6 commits into from Oct 28, 2019

Conversation

@JoeRobich
Copy link
Collaborator

JoeRobich commented Oct 24, 2019

No description provided.

"MonoRuntimeLinux32": "mono.linux-x86-6.4.0.198.zip",
"MonoRuntimeLinux64": "mono.linux-x86_64-6.4.0.198.zip",
"MonoMSBuildRuntime": "Microsoft.Build.Runtime.Mono-6.4.0.198.zip",
"MonoMSBuildLib": "Microsoft.Build.Lib.Mono-6.4.0.198.zip",

This comment has been minimized.

Copy link
@filipw

filipw Oct 25, 2019

Member

maybe we can drop this completely. at the moment, the way build script has been changed recently - it doesn't take msbuild from these ZIPs anyway, it copies it from the global Mono on the build agent (since those are configured to use Mono 6.4.0).

This comment has been minimized.

Copy link
@filipw

filipw Oct 25, 2019

Member

the embedded mono, on the contrary, is still taken from here so that part is still relevant

This comment has been minimized.

Copy link
@JoeRobich

JoeRobich Oct 25, 2019

Author Collaborator

Ah, so a minimal install of mono is now built into and installed with omnisharp instead of omnisharp installing these artifacts?

This comment has been minimized.

Copy link
@JoeRobich

JoeRobich Oct 25, 2019

Author Collaborator

Nevermind my assumption, apparently github only loaded the first of your comments.

This comment has been minimized.

Copy link
@filipw

filipw Oct 25, 2019

Member

yeah no problem 😀

it's not immediately obvious as the build script is quite convoluted, but basically "both" (I quote "both" since there is more of them, but there are two variants - mono and msbuild) these ZIPs are downloaded at build time and embedded into the produced packages. however, since recent changes to move to msbuild 16.3, the msbuild binaries are actually copied from build agent's mono so the msbuild zip here is probably redundant (or we go back to the original approach and stop copying it from build agent's mono).

This comment has been minimized.

Copy link
@JoeRobich

JoeRobich Oct 25, 2019

Author Collaborator

Any reason to not go "all in" on the build script and let it package mono as well?

This comment has been minimized.

Copy link
@filipw

filipw Oct 25, 2019

Member

that would make sense to me 👍 especially as it would also make it easier to move to newer versions of mono

in practice it would mean running the mono packaging script instead of this code https://github.com/OmniSharp/omnisharp-roslyn/blob/master/build.cake#L141-L164 at build time

@JoeRobich JoeRobich marked this pull request as ready for review Oct 25, 2019
@filipw
filipw approved these changes Oct 28, 2019
Copy link
Member

filipw left a comment

LGTM! we can do the change discussed here https://github.com/OmniSharp/omnisharp-roslyn/pull/1640/files#r339205666 separately

for now what is important is that the bundled Mono is 6.4.0-based 👏

@JoeRobich

This comment has been minimized.

Copy link
Collaborator Author

JoeRobich commented Oct 28, 2019

I agree. I'll try to find some time to look into the build changes.

@JoeRobich JoeRobich merged commit db5cc36 into OmniSharp:master Oct 28, 2019
6 checks passed
6 checks passed
OmniSharp.omnisharp-roslyn Build #1.34.7-PullRequest1640.9 succeeded
Details
OmniSharp.omnisharp-roslyn (GitVersion) GitVersion succeeded
Details
OmniSharp.omnisharp-roslyn (Linux) Linux succeeded
Details
OmniSharp.omnisharp-roslyn (Release) Release succeeded
Details
OmniSharp.omnisharp-roslyn (Windows) Windows succeeded
Details
OmniSharp.omnisharp-roslyn (macOS) macOS succeeded
Details
mholo65 added a commit that referenced this pull request Oct 30, 2019
Added #1640 to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.