Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set compilation platform of the project #2135

Merged
merged 5 commits into from Apr 16, 2021
Merged

Conversation

@filipw
Copy link
Member

@filipw filipw commented Apr 15, 2021

Platform property of the compilation options should be based on the PlatformTarget MSBuild property.

Copy link
Member

@bjorkstromm bjorkstromm left a comment

LGTM!

@filipw filipw merged commit 2b2c41b into master Apr 16, 2021
16 checks passed
16 checks passed
@github-actions
Build (ubuntu-18.04) Build (ubuntu-18.04)
Details
@github-actions
Test (ubuntu-18.04, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Om... Test (ubuntu-18.04, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Om...
Details
@github-actions
Build (windows-2019)
Details
@github-actions
Test (ubuntu-18.04, OmniSharp.DotNetTest.Tests) Test (ubuntu-18.04, OmniSharp.DotNetTest.Tests)
Details
@github-actions
Build (macos-10.15)
Details
@github-actions
Test (windows-2019, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Om... Test (windows-2019, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Om...
Details
@github-actions
Test (windows-2019, OmniSharp.DotNetTest.Tests) Test (windows-2019, OmniSharp.DotNetTest.Tests)
Details
@github-actions
Test (macos-10.15, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Omn... Test (macos-10.15, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Omn...
Details
@github-actions
Test (macos-10.15, OmniSharp.DotNetTest.Tests) Test (macos-10.15, OmniSharp.DotNetTest.Tests)
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn Build #1.37.9-PullRequest2135.19 succeeded
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn (GitVersion) GitVersion succeeded
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn (Linux) Linux succeeded
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn (Release) Release succeeded
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn (Windows) Windows succeeded
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
@filipw filipw deleted the feature/platformtarget branch Apr 16, 2021
@filipw filipw restored the feature/platformtarget branch Apr 16, 2021
@filipw filipw deleted the feature/platformtarget branch Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants