Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong-name sign OmniSharp assemblies #2143

Merged
merged 9 commits into from May 1, 2021
Merged

Strong-name sign OmniSharp assemblies #2143

merged 9 commits into from May 1, 2021

Conversation

@333fred
Copy link
Contributor

@333fred 333fred commented Apr 30, 2021

In order to use dotnet/roslyn#52907, we're going to need to strong-name sign the OmniSharp assemblies. This does just that.

@333fred
Copy link
Contributor Author

@333fred 333fred commented Apr 30, 2021

@filipw @david-driscoll please take a look.

@filipw
filipw approved these changes Apr 30, 2021
Copy link
Member

@filipw filipw left a comment

LGTM thank you

Copy link
Member

@bjorkstromm bjorkstromm left a comment

LGTM!

@filipw filipw merged commit d52c76d into OmniSharp:master May 1, 2021
16 checks passed
16 checks passed
@github-actions
Build (ubuntu-18.04)
Details
@github-actions
Test (ubuntu-18.04, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Om... Test (ubuntu-18.04, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Om...
Details
@github-actions
Build (windows-2019)
Details
@github-actions
Test (ubuntu-18.04, OmniSharp.DotNetTest.Tests) Test (ubuntu-18.04, OmniSharp.DotNetTest.Tests)
Details
@github-actions
Build (macos-10.15)
Details
@github-actions
Test (windows-2019, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Om... Test (windows-2019, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Om...
Details
@github-actions
Test (windows-2019, OmniSharp.DotNetTest.Tests) Test (windows-2019, OmniSharp.DotNetTest.Tests)
Details
@github-actions
Test (macos-10.15, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Omn... Test (macos-10.15, OmniSharp.MSBuild.Tests,OmniSharp.Roslyn.CSharp.Tests,OmniSharp.Cake.Tests,Omn...
Details
@github-actions
Test (macos-10.15, OmniSharp.DotNetTest.Tests) Test (macos-10.15, OmniSharp.DotNetTest.Tests)
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn Build #1.37.9-PullRequest2143.41 succeeded
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn (GitVersion) GitVersion succeeded
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn (Linux) Linux succeeded
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn (Release) Release succeeded
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn (Windows) Windows succeeded
Details
@azure-pipelines
OmniSharp.omnisharp-roslyn (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
@333fred 333fred deleted the 333fred:signing branch May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants