Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Microsoft.Build.Locator package for discovery #2181

Merged
merged 1 commit into from Jun 21, 2021

Conversation

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Jun 19, 2021

Thought this might be a good change to backport from the vnext branch.

filipw
filipw approved these changes Jun 20, 2021
Copy link
Member

@filipw filipw left a comment

This looks like a terrific idea to me 👏
thank you for porting this. one thing that occurred to me is that it may change the meaning of "useglobalmono": "always".

Perhaps we could consider adding a flag to be able to force the Mono instance provider with highest priority

@JoeRobich
Copy link
Member Author

@JoeRobich JoeRobich commented Jun 21, 2021

one thing that occurred to me is that it may change the meaning of "useglobalmono": "always".

@filipw hmm.. This should only replace the VS and DevConsole providers. The new instance provider shouldn't return instances on non-Windows platforms. Should I change the check to not return instances on Mono platforms?

@filipw
Copy link
Member

@filipw filipw commented Jun 21, 2021

ugh sorry I missed the (!PlatformHelper.IsWindows) check that returns no instances 🤦‍♂️

@filipw filipw merged commit 0f72656 into OmniSharp:master Jun 21, 2021
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants