Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use IgnoreCorLibraryDuplicatedTypes binder flag in scripts #785

Merged
merged 3 commits into from
Mar 1, 2017

Conversation

filipw
Copy link
Member

@filipw filipw commented Feb 28, 2017

This is what the Roslyn Script Compiler API does internally (see https://github.com/dotnet/roslyn/blob/version-2.0.0-rc4/src/Scripting/CSharp/CSharpScriptCompiler.cs#L67). We should do the same in order to avoid invalid error reporting in some cases (unfortunately the API required is internal).

Fixes #784

@DustinCampbell
Copy link
Contributor

  • @tmat as FYI about needing a public API to avoid using reflection.

Copy link
Contributor

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's dirty, but it looks like that's the best you can do.

@tmat
Copy link
Contributor

tmat commented Feb 28, 2017

The underlying issue is being addressed in Core CLR: https://github.com/dotnet/corefx/issues/5540
I'd suggest creating a tracking issue to remove the reflection once the Core CLR fix ships.

@DustinCampbell
Copy link
Contributor

Good idea -- thanks Tomas!

@filipw
Copy link
Member Author

filipw commented Mar 1, 2017

Thanks guys 👍

I opened a tracking issues #786.
BTW, looks like the exact same reflection based trick is implemented in PowerShell PowerShell/PowerShell#2704 and in Orleans dotnet/orleans#2466.

@filipw filipw merged commit c056965 into OmniSharp:dev Mar 1, 2017
@filipw filipw deleted the features/duplicateCor branch March 1, 2017 07:55
@tmat
Copy link
Contributor

tmat commented Mar 1, 2017

Yes, I'm aware of these two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants