added support for disabling any project system via configuration #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
Jun 30, 2017
david-driscoll
approved these changes
Jun 30, 2017
|
This indirectly can help against #896 too |
|
I looks to me like this one is ready to go. Do you not have merge access @filipw? |
|
I do! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we had logic in place that allowed users to disable the "legacy"
project.jsonproject system - using a configuration flag fromomnisharp.jsonor any other of the several configuration sources we have in place.For consistency, this PR extends this concept to allow the
"enabled": falseflag to be used against MsBuild and Script project systems too.It can help for example performance, as the user can easily (even globally) switch off scanning of the file system done by these project systems.
I also moved out some of the logic from the
Startupclass because, well, SRP.