regression fix - revert cd7b3c369b7c77540aee5d8eec7924a8c59d414d #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
force-pushed
the
bugfix/cd7b3c369b7c77540aee5d8eec7924a8c59d414d
branch
from
f5f0d9f
to
41206f3
Compare
DustinCampbell
approved these changes
Jul 14, 2017
david-driscoll
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the change introduced in cd7b3c3
Functionally everything is the same.
The problem is when we switched to using
IAssemblyLoader, we would now throw (sinceIAssemblyLoaderrethrows the exceptions it encounters) when i.e.System.Runtimeis not found and we'd like to avoid that. For simplicity, it makes sense for us to always try to loadSystem.Runtimeif we can.The alternative wold be to make
IAssemblyLoadernot rethrow anymore, but it would still log errors into the command line which is not good.Due to this issue the scripting project system for desktop is broken on Windows at the moment.