New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor package references, shared project properties, and build output #954

Merged
merged 12 commits into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@DustinCampbell
Contributor

DustinCampbell commented Sep 5, 2017

This PR makes several changes to how our projects are defined and where binaries are built to:

  1. Package versions are defined in a single Package.props MSBuild file.
  2. Shared project properties (such as TreatWarningsAsErrors) are defined in a single Settings.pop MSBuild file.
  3. All bin and obj folders are now located in a top-level bin folder rather than under each project. These are laid out like so:
    • bin -> bin\$(Configuration)\${MSBuildProjectName. So, building OmniSharp.Roslyn in the Debug configuration builds to $omnisharp_root\bin\Debug\OmniSharp.Roslyn.
    • obj -> bin\obj\${MSBuildProjectName). So, the intermediate output path when building OmniSharp.Roslyn in Debug configuration is $omnisharp_root\bin\obj\OmniSharp.Roslyn

@DustinCampbell DustinCampbell requested review from david-driscoll and filipw Sep 5, 2017

@DustinCampbell

This comment has been minimized.

Show comment
Hide comment
@DustinCampbell

DustinCampbell Sep 5, 2017

Contributor

@david-driscoll: If you're good with this change, I'm going to wait until the Kestrel PR is in before merging it in. I'd rather merge it with your changes than force you to merge with mine.

Contributor

DustinCampbell commented Sep 5, 2017

@david-driscoll: If you're good with this change, I'm going to wait until the Kestrel PR is in before merging it in. I'd rather merge it with your changes than force you to merge with mine.

<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>

This comment has been minimized.

@filipw

filipw Sep 6, 2017

Member

ooh i like that! 👍👍

@filipw

filipw Sep 6, 2017

Member

ooh i like that! 👍👍

This comment has been minimized.

@david-driscoll

david-driscoll Sep 12, 2017

Member

Holy verbosity! (Though a useful change)

@david-driscoll

david-driscoll Sep 12, 2017

Member

Holy verbosity! (Though a useful change)

@filipw

filipw approved these changes Sep 6, 2017

@DustinCampbell

This comment has been minimized.

Show comment
Hide comment
@DustinCampbell

DustinCampbell Sep 12, 2017

Contributor

Ping @david-driscoll. I updated this with the latest master. Got time to review?

Contributor

DustinCampbell commented Sep 12, 2017

Ping @david-driscoll. I updated this with the latest master. Got time to review?

@DustinCampbell DustinCampbell requested review from david-driscoll and removed request for david-driscoll Sep 12, 2017

<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>

This comment has been minimized.

@david-driscoll

david-driscoll Sep 12, 2017

Member

Holy verbosity! (Though a useful change)

@david-driscoll

david-driscoll Sep 12, 2017

Member

Holy verbosity! (Though a useful change)

@DustinCampbell

This comment has been minimized.

Show comment
Hide comment
@DustinCampbell

DustinCampbell Sep 12, 2017

Contributor

Thanks!

Contributor

DustinCampbell commented Sep 12, 2017

Thanks!

@DustinCampbell DustinCampbell merged commit b52a9d0 into OmniSharp:master Sep 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@filipw

This comment has been minimized.

Show comment
Hide comment
@filipw

filipw Sep 13, 2017

Member

I shamelessly adopted this approach for some other projects 😄

Member

filipw commented Sep 13, 2017

I shamelessly adopted this approach for some other projects 😄

@DustinCampbell DustinCampbell deleted the DustinCampbell:package-refactoring branch Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment