Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOD Use filename instead of ClassName #3385

Merged
merged 3 commits into from Nov 22, 2019
Merged

Conversation

@BaiShouDan
Copy link
Contributor

BaiShouDan commented Oct 31, 2019

ctor snippet use the filename without extension for ClassName,
the user can continue to edit or modify it if necessary.

ctor snippet use the filename without extension for ClassName, 
the user can continue to edit or modify it if necessary.
@BaiShouDan

This comment has been minimized.

Copy link
Contributor Author

BaiShouDan commented Oct 31, 2019

Hello I don't want every time write again the class name so i founded this solution.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #3385 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3385   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          58       58           
  Lines        1572     1572           
  Branches       89       89           
=======================================
  Hits         1410     1410           
  Misses        151      151           
  Partials       11       11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.69% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1da5f...d4410a1. Read the comment docs.

@filipw
filipw approved these changes Nov 22, 2019
Copy link
Member

filipw left a comment

makes sense to me - @JoeRobich ?

@JoeRobich

This comment has been minimized.

Copy link
Contributor

JoeRobich commented Nov 22, 2019

@BaiShouDan Thanks!

@JoeRobich JoeRobich merged commit a443376 into OmniSharp:master Nov 22, 2019
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing 9f1da5f...d4410a1
Details
codecov/project 89.69% remains the same compared to 9f1da5f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
security/snyk - package.json (david-driscoll) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.