Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Razor to work for 3.1 SDKs #3406

Merged
merged 1 commit into from Nov 14, 2019
Merged

Update Razor to work for 3.1 SDKs #3406

merged 1 commit into from Nov 14, 2019

Conversation

@NTaylorMullen
Copy link
Contributor

NTaylorMullen commented Nov 14, 2019

  • These bits include a new Razor language server, O# plugin and VSCode extension that update the Razor experience to work on 3.1 DSKs
- These bits include a new Razor language server, O# plugin and VSCode extension that update the Razor experience to work on 3.1 DSKs
@NTaylorMullen NTaylorMullen requested review from JoeRobich and filipw Nov 14, 2019
@filipw
filipw approved these changes Nov 14, 2019
Copy link
Member

filipw left a comment

LGTM thanks!

@@ -30,7 +30,7 @@
],
"defaults": {
"omniSharp": "1.34.7",
"razor": "1.0.0-alpha3-20190819.3"
"razor": "1.0.0-alpha3-3.1.0-preview3.19563.3"

This comment has been minimized.

Copy link
@filipw

filipw Nov 14, 2019

Member

new versioning scheme?

This comment has been minimized.

Copy link
@NTaylorMullen

NTaylorMullen Nov 14, 2019

Author Contributor

Kind of ya. We moved where we build the Razor VSCode extension pieces into AspNetCore-Tooling and as part of that the versioning changed a lot.

@NTaylorMullen

This comment has been minimized.

Copy link
Contributor Author

NTaylorMullen commented Nov 14, 2019

Feel free to merge on my behalf when the repo is ready for it 😄

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #3406 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3406   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          59       59           
  Lines        1591     1591           
  Branches       89       89           
=======================================
  Hits         1429     1429           
  Misses        151      151           
  Partials       11       11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0375200...65d1fe0. Read the comment docs.

@JoeRobich

This comment has been minimized.

Copy link
Contributor

JoeRobich commented Nov 14, 2019

Thanks!

@JoeRobich JoeRobich merged commit 7c7b906 into master Nov 14, 2019
6 checks passed
6 checks passed
codecov/patch Coverage not affected when comparing 0375200...65d1fe0
Details
codecov/project 89.81% remains the same compared to 0375200
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
security/snyk - package.json (david-driscoll) No new issues
Details
@NTaylorMullen NTaylorMullen deleted the nimullen/updaterazor.3.1 branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.