Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Razor to include more C# actions. #3445

Merged
merged 1 commit into from Dec 9, 2019
Merged

Conversation

@NTaylorMullen
Copy link
Contributor

NTaylorMullen commented Dec 7, 2019

  • Adds support for find all references, go to definition, go to implementation and CodeLens.

  • Fixed several bugs which resulted in the Razor language server crashing.

  • Updated change log to give a brief description of what was added on Razor's side.

  • Updated test-plan to include quick tests of newly added features

  • Working on getting some Razor grammar goods in the box. We'll see if I can get them into a good enough state; if so i'll update the PR.

@ryanbrandenburg @ajaybhargavb Please look over the changelog / test-plan to ensure I didn't miss anything or if I can word something better.

- Adds support for find all references, go to definition, go to implementation and CodeLens.
- Fixed several bugs which resulted in the Razor language server crashing.
- Updated change log to give a brief description of what was added on Razor's side.
- Updated test-plan to include quick tests of newly added features
@NTaylorMullen NTaylorMullen requested review from JoeRobich and filipw Dec 7, 2019
@@ -11,6 +11,13 @@

## 1.21.9 (Not yet released)
* Use the base filename instead of 'ClassName' in ctor snippet (PR:[#3385](https://github.com/OmniSharp/omnisharp-vscode/pull/3385))
* Updated Razor

This comment has been minimized.

Copy link
@NTaylorMullen

NTaylorMullen Dec 7, 2019

Author Contributor

@danroth27 I took the approach of a simple changelog. Thoughts?

This comment has been minimized.

Copy link
@JoeRobich

JoeRobich Dec 7, 2019

Contributor

I dig it!

Copy link
Contributor

ajaybhargavb left a comment

LGTM

@JoeRobich

This comment has been minimized.

Copy link
Contributor

JoeRobich commented Dec 7, 2019

@NTaylorMullen I've rerun the failed CI a couple times to see if it was just being flaky. The failing test has a 15 second time out. Not sure if remapping is pushing this over or not.

@filipw
filipw approved these changes Dec 7, 2019
Copy link
Member

filipw left a comment

cool!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #3445 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3445   +/-   ##
======================================
  Coverage    89.8%   89.8%           
======================================
  Files          59      59           
  Lines        1589    1589           
  Branches       89      89           
======================================
  Hits         1427    1427           
  Misses        151     151           
  Partials       11      11
Flag Coverage Δ
#integration 100% <ø> (?)
#unit 89.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f4c5b...b9d9eb9. Read the comment docs.

@JoeRobich JoeRobich merged commit 256c6c1 into master Dec 9, 2019
6 checks passed
6 checks passed
codecov/patch Coverage not affected when comparing 74f4c5b...b9d9eb9
Details
codecov/project 89.8% remains the same compared to 74f4c5b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
security/snyk - package.json (david-driscoll) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.