Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated Razor grammar for better colorization. #3448

Merged
merged 1 commit into from Dec 9, 2019

Conversation

@NTaylorMullen
Copy link
Contributor

NTaylorMullen commented Dec 9, 2019

  • This is an initial release of Razor's improved grammar. It doesn't support everything but it's superior to what's currently in the box.
  • As part of this grammar we added support for Razor comments. Because of this I've updated the langauge-configuration.json as well to reflect changes from @ajaybhargavb.
  • Things that don't currently work: dotnet/aspnetcore#14287 (comment)
- This is an initial release of Razor's improved grammar. It doesn't support everything but it's superior to what's currently in the box.
- As part of this grammar we added support for Razor comments. Because of this I've updated the langauge-configuration.json as well to reflect [changes](dotnet/aspnetcore-tooling@24c0973) from @ajaybhargavb.
- Things that don't currently work: dotnet/aspnetcore#14287 (comment)
@NTaylorMullen NTaylorMullen requested review from JoeRobich and filipw Dec 9, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #3448 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3448   +/-   ##
======================================
  Coverage    89.8%   89.8%           
======================================
  Files          59      59           
  Lines        1589    1589           
  Branches       89      89           
======================================
  Hits         1427    1427           
  Misses        151     151           
  Partials       11      11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 256c6c1...4962dfd. Read the comment docs.

@NTaylorMullen NTaylorMullen merged commit cd9e970 into master Dec 9, 2019
6 checks passed
6 checks passed
codecov/patch Coverage not affected when comparing 256c6c1...4962dfd
Details
codecov/project 89.8% remains the same compared to 256c6c1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
security/snyk - package.json (david-driscoll) No manifest changes detected
@NTaylorMullen NTaylorMullen deleted the nimullen/razorgrammar branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.