Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use custom runsettings for tests #3573

Merged
merged 2 commits into from Mar 3, 2020

Conversation

@Samirat
Copy link
Contributor

Samirat commented Feb 12, 2020

RunSettings are set as a path by the omnisharp.testRunSettings setting, and then forwarded to the server to use when it run tests.

Related PR to omnisharp-roslyn: OmniSharp/omnisharp-roslyn#1710

@Samirat Samirat changed the title Add option to set custom runsettings for tests Add ability to use custom runsettings for tests Feb 12, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #3573 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3573   +/-   ##
======================================
  Coverage    89.8%   89.8%           
======================================
  Files          59      59           
  Lines        1589    1589           
  Branches       89      89           
======================================
  Hits         1427    1427           
  Misses        151     151           
  Partials       11      11
Flag Coverage Δ
#integration ?
#unit 89.8% <0%> (ø) ⬆️
Impacted Files Coverage Δ
src/constants/CSharpExtensionId.ts 100% <ø> (ø) ⬆️
src/omnisharp/protocol.ts 83.62% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1916b...88b0920. Read the comment docs.

Copy link
Contributor

JoeRobich left a comment

Thanks!

@JoeRobich JoeRobich merged commit 5b8e0cb into OmniSharp:master Mar 3, 2020
4 of 5 checks passed
4 of 5 checks passed
codecov/patch 0% of diff hit (target 89.8%)
Details
codecov/project 89.8% remains the same compared to ae1916b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
security/snyk (david-driscoll) No manifest changes detected
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.