Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Razor version #3594

Merged
merged 2 commits into from Feb 21, 2020
Merged

Conversation

@ajaybhargavb
Copy link
Contributor

ajaybhargavb commented Feb 21, 2020

@ajaybhargavb ajaybhargavb force-pushed the ajaybhargavb:ajbaaska/razor-release branch from 4ce9cef to 6935514 Feb 21, 2020
Copy link
Contributor

JoeRobich left a comment

Great set of improvements!

CHANGELOG.md Outdated Show resolved Hide resolved
@filipw
filipw approved these changes Feb 21, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #3594 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3594   +/-   ##
======================================
  Coverage    89.8%   89.8%           
======================================
  Files          59      59           
  Lines        1589    1589           
  Branches       89      89           
======================================
  Hits         1427    1427           
  Misses        151     151           
  Partials       11      11
Flag Coverage Δ
#integration 100% <ø> (?)
#unit 89.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f67e3...37535b9. Read the comment docs.

Copy link
Contributor

ryanbrandenburg left a comment

After the \u stuff gets reverted :shipit:

@@ -498,17 +498,17 @@
"items": {
"type": "string"
},
"description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",

This comment has been minimized.

Copy link
@ryanbrandenburg

ryanbrandenburg Feb 21, 2020

Contributor

As I recall they had these in there for a reason, you should probably add them back.

This comment has been minimized.

Copy link
@ajaybhargavb

ajaybhargavb Feb 21, 2020

Author Contributor

Oh interesting, I'm curious to know what the reasoning behind this is. @JoeRobich why were these needed?

This comment has been minimized.

Copy link
@JoeRobich

JoeRobich Feb 21, 2020

Contributor

why were these needed?

I have no idea if they are needed. Our update package dependencies launch task will restore them prior to the next release. So no reason to do it here.

"default": []
},
"searchMicrosoftSymbolServer": {
"type": "boolean",
"description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",

This comment has been minimized.

Copy link
@ryanbrandenburg

ryanbrandenburg Feb 21, 2020

Contributor

Same as above for all \u200b.

@NTaylorMullen NTaylorMullen merged commit 28a782d into OmniSharp:master Feb 21, 2020
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing e1f67e3...37535b9
Details
codecov/project 89.8% remains the same compared to e1f67e3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
security/snyk - package.json (david-driscoll) No new issues
Details
@ajaybhargavb ajaybhargavb deleted the ajaybhargavb:ajbaaska/razor-release branch Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.