Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for undefined #3678

Merged
merged 1 commit into from Mar 18, 2020
Merged

Conversation

@ryanbrandenburg
Copy link
Contributor

ryanbrandenburg commented Mar 18, 2020

showWarningMessage returns undefined in the case that the selection from the message is to press the x instead of one of the 'option' buttons, which causes an Error without some sort of check.

@ajaybhargavb

This comment has been minimized.

Copy link
Contributor

ajaybhargavb commented Mar 18, 2020

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #3678 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3678   +/-   ##
=======================================
  Coverage   89.80%   89.80%           
=======================================
  Files          59       59           
  Lines        1589     1589           
  Branches       89       89           
=======================================
  Hits         1427     1427           
  Misses        151      151           
  Partials       11       11           
Flag Coverage Δ
#integration 100.00% <ø> (ø)
#unit 89.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237da87...6bcfbdd. Read the comment docs.

@JoeRobich JoeRobich merged commit 15175f7 into OmniSharp:master Mar 18, 2020
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing 237da87...6bcfbdd
Details
codecov/project 89.80% (+0.00%) compared to 237da87
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
security/snyk (david-driscoll) No manifest changes detected
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.