Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async completion #4116

Merged
merged 5 commits into from May 17, 2021
Merged

Support async completion #4116

merged 5 commits into from May 17, 2021

Conversation

@333fred
Copy link
Collaborator

@333fred 333fred commented Oct 16, 2020

@codecov
Copy link

@codecov codecov bot commented Oct 16, 2020

Codecov Report

Merging #4116 (486c831) into master (0d501a4) will increase coverage by 17.25%.
The diff coverage is 100.00%.

Current head 486c831 differs from pull request most recent head 0e83f1a. Consider uploading reports for the commit 0e83f1a to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4116       +/-   ##
===========================================
+ Coverage   68.76%   86.02%   +17.25%     
===========================================
  Files         109       60       -49     
  Lines        4325     1860     -2465     
  Branches      756      215      -541     
===========================================
- Hits         2974     1600     -1374     
+ Misses       1153      200      -953     
+ Partials      198       60      -138     
Flag Coverage Δ
integration ∅ <ø> (∅)
unit 86.02% <100.00%> (+1.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/omnisharp/options.ts 94.56% <100.00%> (-3.31%) ⬇️
src/omnisharp/protocol.ts 79.57% <100.00%> (-7.84%) ⬇️
src/NetworkSettings.ts 37.50% <0.00%> (-62.50%) ⬇️
src/utils/getDotnetInfo.ts 19.04% <0.00%> (-49.14%) ⬇️
src/observers/TelemetryObserver.ts 76.11% <0.00%> (-20.90%) ⬇️
src/observers/BaseLoggerObserver.ts 60.00% <0.00%> (-20.00%) ⬇️
src/packageManager/PackageError.ts 83.33% <0.00%> (-16.67%) ⬇️
src/packageManager/proxy.ts 42.10% <0.00%> (-15.79%) ⬇️
src/observers/OptionProvider.ts 57.14% <0.00%> (-14.29%) ⬇️
src/common.ts 56.17% <0.00%> (-12.36%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea20d08...0e83f1a. Read the comment docs.

@333fred 333fred force-pushed the 333fred:async-completion branch from 486c831 to 4a9bcf5 Apr 25, 2021
@333fred 333fred marked this pull request as ready for review Apr 25, 2021
333fred added 2 commits May 7, 2021
* upstream/master:
  Define newly added referencesCodeLens.filteredSymbols option in package.json
  Add option for additional filters for codelens suppression
@333fred
Copy link
Collaborator Author

@333fred 333fred commented May 7, 2021

@JoeRobich @filipw for review.

src/omnisharp/protocol.ts Outdated Show resolved Hide resolved
@333fred
Copy link
Collaborator Author

@333fred 333fred commented May 16, 2021

@filipw could you take a look? It'd be good to get this in.

@filipw
filipw approved these changes May 17, 2021
Copy link
Member

@filipw filipw left a comment

looks good to me!

@JoeRobich JoeRobich merged commit f1461bd into OmniSharp:master May 17, 2021
3 checks passed
3 checks passed
@github-actions
build
Details
license/cla All CLA requirements met.
Details
security/snyk (david-driscoll) 1 security test has passed
Details
@333fred 333fred deleted the 333fred:async-completion branch May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants