Permalink
Browse files

escape ; in query values too

  • Loading branch information...
technoweenie committed Jan 4, 2013
1 parent 7a18d8b commit 2dcee48fc61d1043e0a0f0317fd2c807ad6b9e2e
Showing with 2 additions and 1 deletion.
  1. +1 −0 lib/aws/s3.rb
  2. +1 −1 test/object_test.rb
View
@@ -40,6 +40,7 @@ def self.escape_uri_component(path)
escaped = escape_uri(path)
escaped.gsub!(/=/, '%3D')
escaped.gsub!(/&/, '%26')
+ escaped.gsub!(/;/, '%3B')
escaped
end
View
@@ -75,7 +75,7 @@ def test_url_with_custom_query
begin
AWS::S3::Base.connections['AWS::S3::Base'] = conn
- assert_match 'response-content-disposition=attachment;%20filename%3Dfoo.txt',
+ assert_match 'response-content-disposition=attachment%3B%20filename%3Dfoo.txt',
@object.url(:query => {
'response-content-disposition' => 'attachment; filename=foo.txt'})
ensure

0 comments on commit 2dcee48

Please sign in to comment.