Skip to content

Sayali : update bio status filter criteria to use totalValidWeeklySummaries#5261

Open
sayali-2308 wants to merge 3 commits into
developmentfrom
Sayali_Task1_BioStatus_ValidWeeklySummaries
Open

Sayali : update bio status filter criteria to use totalValidWeeklySummaries#5261
sayali-2308 wants to merge 3 commits into
developmentfrom
Sayali_Task1_BioStatus_ValidWeeklySummaries

Conversation

@sayali-2308
Copy link
Copy Markdown
Contributor

image

Description

Fixes #1 (Priority High)

Related PRs:

Replaces PR #3529

Main changes explained:

  • Updated WeeklySummariesReport.jsx to use summary.weeklySummariesCount >= 8 instead of summary.daysInTeam > 60 in isMeetCriteria filter logic
  • Updated FormattedReport.jsx same criteria fix for bio highlight (yellow background)
  • Updated BioFunction.jsx to use totalValidWeeklySummaries prop instead of daysInTeam
  • Updated test files BioFunction.test.jsx and FormattedReport.test.jsx to reflect new prop names

How to test:

  1. Check out branch Sayali_Task1_BioStatus_ValidWeeklySummaries
  2. npm install && npm run start:local
  3. Clear cache, log in as admin
  4. Navigate to Reports → Weekly Summaries Report
  5. Toggle Bio Status filter ON
  6. Verify only users with 80+ tangible hours AND 8+ Total Valid Weekly Summaries appear
  7. Verify eligible users have yellow highlight on Bio announcement row
  8. Verify dark mode works

Screenshots:

image image

Note:

Frontend-only change. No backend changes required.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 3e20e15
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a110b982b30a50008f4e6df
😎 Deploy Preview https://deploy-preview-5261--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sayali-2308 sayali-2308 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label May 13, 2026
kunchalasireesha

This comment was marked as resolved.

Copy link
Copy Markdown

@kunchalasireesha kunchalasireesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a heads-up: the UI seems a little broken in dark mode. If it's unrelated to this ticket, we can just spin up a new ticket for it and merge this.

Screen.Recording.2026-05-16.at.7.18.53.PM.mov

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sayali,

Functional behavior looks good. Bio Status filter, 80+ hour threshold, 8+ summary check, and yellow highlight all work correctly.
One issue before merging: the page looks off in dark mode. Please review the dark mode styling.

Image Image Image

Copy link
Copy Markdown

@DeepighaJ DeepighaJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked out to current branch and tested PR locally.
  • Bio Status toggle works as expected and filters out team members with highlight also works as expected.
  • The dark mode still needs improvement the highlighted text is not readable.
Image Image Image Image

@sayali-2308 sayali-2308 changed the title Sayali : update bio status filter criteria to use totalValidWeeklySummaries >= 8 instead of daysInTeam > 60 Sayali : update bio status filter criteria to use totalValidWeeklySummaries May 22, 2026
@sayali-2308
Copy link
Copy Markdown
Contributor Author

  • Checked out to current branch and tested PR locally.
  • Bio Status toggle works as expected and filters out team members with highlight also works as expected.
  • The dark mode still needs improvement the highlighted text is not readable.

Image Image Image Image

@sonarqubecloud
Copy link
Copy Markdown

@sayali-2308
Copy link
Copy Markdown
Contributor Author

HI @DeepighaJ and @HemanthNidamanuru
thank you for the review! I've fixed the dark mode styling issue. The bio highlight text now shows black text on yellow background for readability, and the card content (Media URL, Total Valid Weekly Summaries, Hours logged, Weekly Summary) is now visible in dark mode by adding text-light and overriding Bootstrap's list-group-item background with bg-yinmn-blue. Please review again!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants