Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to enable install on Windows 10 #55

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@ajkauffmann
Copy link

ajkauffmann commented Feb 26, 2019

Script doesn't support installation on latest Windows 10 versions because of an incorrect test. However, it can run the same code for both Windows 10 and Windows Server.
Windows Server supports both Install-WindowsFeature and Enable-WindowsOptionalFeature.
The difference is that Install-WindowsFeature can be used for both local and remote machine, whereas Enable-WindowsOptionalFeature is only for local machine.
We are not installing in a remote machine, so we safely use Enable-WindowsOptionalFeature, no matter if the install runs on Windows 10 or Windows Server.

Other changes:

  • Add an option 'isolationMode' to set the default isolation mode
  • Clean up of some unusual PowerShell notation

ajkauffmann added some commits Feb 4, 2019

Enable Windows 10
Extra parameter for isolation mode
Clean up code a bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.