New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim off excess from GitCommitId in PSCore daily builds #309

Merged
merged 3 commits into from Sep 8, 2017

Conversation

Projects
None yet
4 participants
@brywang-msft
Contributor

brywang-msft commented Sep 7, 2017

Fixes test issue when using the daily builds of PowerShell Core. Plan on cherry picking cda0755 to master.

@brywang-msft brywang-msft requested a review from jianyunt Sep 7, 2017

@jianyunt jianyunt added the Discussion label Sep 7, 2017

# Trim off excess from the GitCommitId for daily builds of PSCore
while (($latestPsVersion.Length -gt 1) -and (-not (Test-Path $moduleBaseCandidate)))
{
$latestPsVersion = $latestPsVersion.Substring(0, $latestPsVersion.Length-1)

This comment has been minimized.

@Krishna-Vutukuri

Krishna-Vutukuri Sep 7, 2017

Doesn't Trim or TrimEnd() not work?

@Krishna-Vutukuri

Krishna-Vutukuri Sep 7, 2017

Doesn't Trim or TrimEnd() not work?

@brywang-msft brywang-msft merged commit 82b2eb9 into OneGet:WIP Sep 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jianyunt jianyunt removed the Discussion label Sep 8, 2017

brywang-msft added a commit that referenced this pull request Sep 8, 2017

Trim off excess from GitCommitId in PSCore daily builds (#309)
Trim off excess from the GitCommitId in PSCore daily builds

brywang-msft added a commit that referenced this pull request Oct 13, 2017

Merge 'WIP' to 'master' (#317)
* Back compat with older builds of PowerShell Core (#300)

Back compat with older builds of PowerShell Core (#300)

* readme update for new build phase

* Update submodules

* Submodule update

* Support prerelease values for *Version parameters of Get-Package and Uninstall-Package cmdlets

Added support for prerelease version values for MinimumVersion, MaximumVersion and RequiredVersion parameters on Get-Package and Uninstall-Package cmdlets.

Resolves #306

* Trim off excess from GitCommitId in PSCore daily builds (#309)

Trim off excess from the GitCommitId in PSCore daily builds

* Submodule update + small version bump (#316)

Submodule update + small version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment