New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for NuGetProvider NuGet v3 support #326

Merged
merged 16 commits into from Dec 14, 2017

Conversation

Projects
None yet
2 participants
@brywang-msft
Contributor

brywang-msft commented Dec 11, 2017

PackageManagement changes to include NuGet v3 in NuGetProvider.

  • Test script updates
    1. Support NuGet.org v2/v3 URLs
    2. Remove Search -AllVersions scenario (now expect to fail)
  • AppVeyor/Travis updates
  • Build script fixes

@brywang-msft brywang-msft requested a review from bmanikm Dec 11, 2017

@brywang-msft

This comment has been minimized.

Show comment
Hide comment
@brywang-msft

brywang-msft Dec 11, 2017

Contributor

Pending: Trying to figure out where our AppVeyor and Travis checks went!

Contributor

brywang-msft commented Dec 11, 2017

Pending: Trying to figure out where our AppVeyor and Travis checks went!

@@ -105,7 +105,7 @@ Describe "find-packageprovider" -Tags "Feature" {
$a -contains "TSDProvider" | should be $true
$b = (Find-PackageProvider -name TSDP* -AllVersions).name
$b.Count -ge $a.Count | should be $true
$b.Count -ge $a.Count | should be $false

This comment has been minimized.

@bmanikm

bmanikm Dec 12, 2017

Collaborator

$false [](start = 42, length = 6)

Can you explain the reason for this change?

@bmanikm

bmanikm Dec 12, 2017

Collaborator

$false [](start = 42, length = 6)

Can you explain the reason for this change?

This comment has been minimized.

@brywang-msft

brywang-msft Dec 12, 2017

Contributor

This is what we talked about with Keith. You can also see the reason by checking the warning message:
WARNING: When searching using one or more wildcards, the AllVersions switch is not supported. This policy is in place
to help alleviate stress on search services.

@brywang-msft

brywang-msft Dec 12, 2017

Contributor

This is what we talked about with Keith. You can also see the reason by checking the warning message:
WARNING: When searching using one or more wildcards, the AllVersions switch is not supported. This policy is in place
to help alleviate stress on search services.

@brywang-msft

This comment has been minimized.

Show comment
Hide comment

@brywang-msft brywang-msft merged commit 6a62786 into OneGet:WIP Dec 14, 2017

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment