New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InternalsVisibleTo attribute for separate NuGetProvider build #339

Merged
merged 5 commits into from Mar 1, 2018

Conversation

Projects
None yet
2 participants
@brywang-msft
Contributor

brywang-msft commented Feb 26, 2018

Small bump to allow NuGetProvider to reference Microsoft.PackageManagement.dll in build instead of copying files. Plan is to publish as NuGet package only with version 1.2.1-preview. No reason to publish this iteration as a module.

@brywang-msft brywang-msft requested a review from jianyunt Feb 26, 2018

@jianyunt jianyunt added the Discussion label Feb 26, 2018

@@ -26,6 +26,9 @@ param(
Import-Module "$PSScriptRoot\TestUtility.psm1" -Force
# Set default TLS version to one supported by GitHub, in case PSCore needs to be downloaded
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12

This comment has been minimized.

@jianyunt

jianyunt Feb 27, 2018

Contributor

that's the reason we are failing on downloading pscore?

This comment has been minimized.

@brywang-msft

brywang-msft Feb 27, 2018

Contributor

Think so, we'll see in an hour :(

See Raghu's message on PowerShell Teams channel.

@brywang-msft

This comment has been minimized.

Contributor

brywang-msft commented Feb 27, 2018

@brywang-msft brywang-msft merged commit 8e1f18e into OneGet:WIP Mar 1, 2018

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment