New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for find/install NuGet package via VSTS feed #369

Merged
merged 3 commits into from Aug 27, 2018

Conversation

Projects
None yet
4 participants
@alerickson
Collaborator

alerickson commented Aug 16, 2018

Find-Package, Install-Package, Save-Package, and Register-PackageSource tests for changes made in NuGetProvider repository.

@alerickson alerickson requested review from bmanikm, edyoung and jianyunt Aug 16, 2018

Show outdated Hide outdated Test/ModuleTests/tests/vsts.tests.ps1
Show outdated Hide outdated Test/ModuleTests/tests/vsts.tests.ps1
Show outdated Hide outdated Test/ModuleTests/tests/vsts.tests.ps1
Show outdated Hide outdated Test/ModuleTests/tests/vsts.tests.ps1
Show outdated Hide outdated Test/ModuleTests/tests/vsts.tests.ps1
Show outdated Hide outdated Test/ModuleTests/tests/vsts.tests.ps1
$pkgSource.Location | Should Be $VSTSsource
# Clean-up - unregister the package source
$packageSource = Get-PackageSource -Name $pkgSourceName -ErrorAction SilentlyContinue -WarningAction SilentlyContinue

This comment has been minimized.

@bmanikm

bmanikm Aug 20, 2018

Collaborator

$packageSource = Get-PackageSource -Name $pkgSourceName -ErrorAction SilentlyContinue -WarningAction SilentlyContinue [](start = 8, length = 117)

Consider adding an assertion here to ensure that the registered package source got persisted.

@bmanikm

bmanikm Aug 20, 2018

Collaborator

$packageSource = Get-PackageSource -Name $pkgSourceName -ErrorAction SilentlyContinue -WarningAction SilentlyContinue [](start = 8, length = 117)

Consider adding an assertion here to ensure that the registered package source got persisted.

@jianyunt

This comment has been minimized.

Show comment
Hide comment
@jianyunt

jianyunt Aug 22, 2018

Contributor

@alerickson the test looks fine to me. However OneGet checkin and daily test runs are busted. A few issues:

  1. Test runs are not reported in PR. -- Missing from the above all checks.
  2. If you go to Appveryor site, https://ci.appveyor.com/project/jianyunt/oneget/build/1.0.531/job/m2q688474fqwr3y6
    it reported as pass, actually failed.

We have a couple of options:

  1. Check in your tests first and fix the existing ones.
  2. Fix the existing test runs to make it pass first.

By the way, your vsts test will fail in checkin test.

Contributor

jianyunt commented Aug 22, 2018

@alerickson the test looks fine to me. However OneGet checkin and daily test runs are busted. A few issues:

  1. Test runs are not reported in PR. -- Missing from the above all checks.
  2. If you go to Appveryor site, https://ci.appveyor.com/project/jianyunt/oneget/build/1.0.531/job/m2q688474fqwr3y6
    it reported as pass, actually failed.

We have a couple of options:

  1. Check in your tests first and fix the existing ones.
  2. Fix the existing test runs to make it pass first.

By the way, your vsts test will fail in checkin test.

@alerickson

This comment has been minimized.

Show comment
Hide comment
@alerickson

alerickson Aug 22, 2018

Collaborator

@jianyunt I'll check in my tests then fix the existing ones. My tests are supposed to be run manually anyway- I had forgotten to uncomment the return statement at the beginning of the file.

Collaborator

alerickson commented Aug 22, 2018

@jianyunt I'll check in my tests then fix the existing ones. My tests are supposed to be run manually anyway- I had forgotten to uncomment the return statement at the beginning of the file.

@jianyunt

This comment has been minimized.

Show comment
Hide comment
@jianyunt

jianyunt Aug 27, 2018

Contributor

@alerickson thanks. I created a new issue and assigned to you. #371.

Contributor

jianyunt commented Aug 27, 2018

@alerickson thanks. I created a new issue and assigned to you. #371.

@jianyunt jianyunt merged commit bcc40ba into OneGet:WIP Aug 27, 2018

1 check passed

license/cla All CLA requirements met.
Details
@alerickson

This comment has been minimized.

Show comment
Hide comment
@alerickson

alerickson Sep 6, 2018

Collaborator

resolves #341

Collaborator

alerickson commented Sep 6, 2018

resolves #341

@alerickson alerickson deleted the alerickson:installPackageVSTSFeed branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment