Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Provide style customization options #13
looks like GraphiQL explorer was made with GraphiQL and so works with the styling available with GraphiQL. This makes it difficult to use it in other non-GraphiQL based projects, like Altair.
@FluorescentHallucinogen has previously created an issue on the Altair repo to integrate GraphiQL explorer (imolorhe/altair#534) and sufficient progress on that has been done already. However, we are facing a bit of styling issues.
Altair makes use of themes extensively with different styling options. While there are ways to make the styling work, I was hoping for a more standard approach from GraphiQL explorer itself.
@imolorhe That's great, I'm a big fan of Altair!
For styling in the short term, I think we should allow a custom set of style objects to be passed in to the explorer that will be merged with the default. That way the defaults are always there and it works for people who don't know to customize it, but the defaults are easy to override when advanced users (like you) want to.
Beyond that, I'd like for GraphiQL itself to adopt a theming approach that we can fall in line with, and that'll naturally mean that it's easy to interact with from projects like yours.
@sgrove I'm glad to hear that. It's always refreshing to know that major community contributors like yourself are a fan of the project.
I do think providing the option to pass custom styling as a prop would work for Altair's use case.
That can be a point to consider during the meeting with the GraphiQL working group (which I assume you are going to be attending
The demo graphql explorer plugin for Altair: https://github.com/imolorhe/graphql-explorer
@FluorescentHallucinogen There's a live demo you can play with now: https://plugin-dev-2-branch-altair-imolorhe.surge.sh/
You would need to enable the