Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions controller debug #10

Merged
merged 2 commits into from Mar 2, 2012
Merged

Sessions controller debug #10

merged 2 commits into from Mar 2, 2012

Conversation

geoffroh
Copy link
Contributor

@geoffroh geoffroh commented Mar 2, 2012

Hi Mikel & Glenn
Here are some changes to the cassy gem:

  • removing the 500 errors after logging in if the requested service isn't in the service list
  • adding the optional config setting of a 'default_service_url' so that if the requested service isn't correct it will redirect to here after logging in
  • adding the optional config setting of 'loosely_match_services' so that a ticket for (eg) something.com will work when the requested service is on the same domain (eg something.com/something_else)

Geoff

…service isn't in the service_list. Also added some functionality for providing a default_service in the cassy config file - so that cassy will redirect here if the requested service isn't valid; and for loosening up the way which cassy matches the requested service to tickets - so that (for eg) http://www.something.com/something_else can be matched to http://www.something.com.
@mikel
Copy link
Contributor

mikel commented Mar 2, 2012

Looks good overall, Glenn cast your eye over it as you are probably the one who is going to be fixing it if it breaks :)

glenndavy added a commit that referenced this pull request Mar 2, 2012
@glenndavy glenndavy merged commit 88dead3 into OneHQ:master Mar 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants