-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Testing #65
Improved Testing #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # build.gradle.kts # src/test/java/net/minestom/server/collision/EntityBlockPhysicsIntegrationTest.java # src/test/java/net/minestom/server/entity/EntityMetaIntegrationTest.java # src/test/java/net/minestom/server/entity/EntityViewDirectionIntegrationTest.java # src/test/java/net/minestom/server/entity/player/PlayerBlockPlacementIntegrationTest.java # src/test/java/net/minestom/server/instance/BiomeIntegrationTest.java # src/test/java/net/minestom/server/instance/GeneratorIntegrationTest.java # src/test/java/net/minestom/server/instance/InstanceBlockIntegrationTest.java # src/test/java/net/minestom/server/instance/InstanceBlockPacketIntegrationTest.java # src/test/java/net/minestom/server/instance/WorldBorderIntegrationTest.java # src/test/java/net/minestom/server/instance/anvil/AnvilLoaderIntegrationTest.java # src/test/java/net/minestom/server/instance/generator/GeneratorForkConsumerIntegrationTest.java # src/test/java/net/minestom/server/instance/light/LightParityIntegrationTest.java # src/test/java/net/minestom/server/inventory/InventoryIntegrationTest.java # src/test/java/net/minestom/server/item/ItemAttributeTest.java
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
1 similar comment
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Proposed changes
This PR improves testing for developers and internally. To bring us closer to JUnit5.
The version has been upgraded to 1.5.0.
All tests have been adapted to the new environment. And old things have been deprecated and marked with a replacement
Closes #62
Types of changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...