Skip to content

Reimplement Firefox onInstall logic #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leakymemory merged 1 commit into from
Sep 6, 2016
Merged

Reimplement Firefox onInstall logic #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/scripts/extensions/webExtensionBase/webExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,11 @@ export class WebExtension extends ExtensionBase<WebExtensionWorker, W3CTab, numb
}

protected onFirstRun() {
// Don't do anything since we're using the onInstalled functionality instead
// Don't do anything since we're using the onInstalled functionality instead, unless it's not available
// then we use our 'missing-clipperId' heuristic
if (!this.onInstalledSupported()) {
this.onInstalled();
}
}

protected checkIfTabMatchesATooltipType(tab: W3CTab, tooltipType: TooltipType): boolean {
Expand Down Expand Up @@ -158,7 +162,7 @@ export class WebExtension extends ExtensionBase<WebExtensionWorker, W3CTab, numb

private registerInstallListener() {
// onInstalled is undefined as of Firefox 48
if (WebExtension.browser.runtime.onInstalled) {
if (this.onInstalledSupported()) {
WebExtension.browser.runtime.onInstalled.addListener(details => {
if (details.reason === "install") {
this.onInstalled();
Expand All @@ -175,4 +179,8 @@ export class WebExtension extends ExtensionBase<WebExtensionWorker, W3CTab, numb
}
});
}

private onInstalledSupported(): boolean {
return !!WebExtension.browser.runtime.onInstalled;
}
}