Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,23 @@ on:
- ".github/**"
- ".vscode/**"
- "README.md"
workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest
container:
image: ghcr.io/cirruslabs/flutter:3.35.5

steps:
- name: Checkout OneSignal-Flutter-SDK
uses: actions/checkout@v5

- name: Install Dependencies 🔗⛓📦
- name: Set up Flutter
uses: subosito/flutter-action@v2
with:
channel: stable
flutter-version: 3.35.5
cache: true

- name: Install
run: flutter pub get

- name: Static Analysis
Expand All @@ -29,4 +33,4 @@ jobs:
run: dart format --set-exit-if-changed --output=none .

- name: Run Flutter unit tests
run: flutter test
run: dart run rps test
6 changes: 3 additions & 3 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version: 5.3.4
homepage: https://github.com/OneSignal/OneSignal-Flutter-SDK

scripts:
test: dlcov -c 80 --lcov-gen="flutter test --coverage" --include-untested-files=true
test: flutter test --coverage && dart run dlcov -c 80 --log=0 --include-untested-files=true

flutter:
plugin:
Expand All @@ -27,5 +27,5 @@ dev_dependencies:
rps: ^0.9.1

environment:
sdk: ">=2.12.0 <3.0.0"
flutter: ">=1.10.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.0.0"
7 changes: 0 additions & 7 deletions test/mock_channel.dart
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,6 @@ class OneSignalMockChannelController {
case "OneSignal#removeExternalUserId":
state.externalId = null;
return {"success": true};
case "OneSignal#setLanguage":
state.language =
(call.arguments as Map<dynamic, dynamic>)['language'] as String?;
return {"success": true};
case "OneSignal#requestPermission":
// Location requestPermission (no arguments)
if (call.arguments == null) {
Expand Down Expand Up @@ -204,9 +200,6 @@ class OneSignalMockChannelController {
break;
case "OneSignal#arePaused":
return state.inAppMessagesPaused ?? false;
case "OneSignal#lifecycleInit":
state.lifecycleInitCalled = true;
break;
case "OneSignal#displayNotification":
// This is called on OneSignal#notifications channel
state.displayedNotificationId = (call.arguments
Expand Down