Fix Type Conversion Warning #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Fixes an issue with the SDK that would print a warning for the private _handleMethod() method. • It was returning the results of calling private handler references, which themselves returned void. However the function is defined to return Future<Null> not void, so a warning was printed. • Fixed by returning null at the end. The result of this function is not used and the SDK does not need to wait asynchronously for the handlers to finish executing.
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Fixes an issue with the SDK that would print a warning for the private _handleMethod() method.
• It was returning the results of calling private handler references, which themselves returned void. However the function is defined to return Future not void, so a warning was printed.
• Fixed by returning null at the end. The result of this function is not used and the SDK does not need to wait asynchronously for the handlers to finish executing.
• Fixes #14
NOTE The typical reviewer for these PR's (@jkasten2) is out on vacation for the next week, so to avoid delaying builds, we will merge and release without review.