From 30045d034875dbfe38fb5e377efa44689d00de8f Mon Sep 17 00:00:00 2001 From: Brad Hesse Date: Wed, 15 Aug 2018 15:22:11 -0700 Subject: [PATCH] Fix Incorrect Context MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit • The OneSignalPlugin was initializing the native OneSignal SDK with an incorrect context. Switched to using the flutter registrar's activeContext instead. • This would have caused the SDK to always believe that the app was not currently in focus, meaning the SDK would ignore the current inFocusDisplayType option and always show notifications as normal Android notifications --- .../main/java/com/onesignal/flutter/OneSignalPlugin.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/android/src/main/java/com/onesignal/flutter/OneSignalPlugin.java b/android/src/main/java/com/onesignal/flutter/OneSignalPlugin.java index af259f9e..7ed88415 100644 --- a/android/src/main/java/com/onesignal/flutter/OneSignalPlugin.java +++ b/android/src/main/java/com/onesignal/flutter/OneSignalPlugin.java @@ -98,7 +98,7 @@ else if (call.method.contentEquals("OneSignal#didSetNotificationOpenedHandler")) private void initOneSignal(MethodCall call, Result result) { String appId = call.argument("appId"); - Context context = flutterRegistrar.context(); + Context context = flutterRegistrar.activeContext(); OneSignal.Builder builder = OneSignal.getCurrentOrNewInitBuilder(); builder.unsubscribeWhenNotificationsAreDisabled(true); @@ -164,8 +164,8 @@ private void getPermissionSubscriptionState(Result result) { } private void setInFocusDisplayType(MethodCall call, Result result) { - int deplayType = call.argument("displayType"); - OneSignal.setInFocusDisplaying(deplayType); + int displayType = call.argument("displayType"); + OneSignal.setInFocusDisplaying(displayType); result.success(null); }