Skip to content

Conversation

@adamschlesinger
Copy link
Contributor

@adamschlesinger adamschlesinger commented Dec 2, 2021

Pull request for version 2.14.6


This change is Reviewable

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @adamschlesinger)


OneSignalExample/Assets/OneSignal/CHANGELOG.md, line 49 at r2 (raw file):

      the [README](https://github.com/OneSignal/OneSignal-Unity-SDK/README.md#unity-asset-store) to ensure a smooth transition.

[Unreleased]: https://github.com/OneSignal/OneSignal-Unity-SDK/compare/2.14.5...HEAD

This line needs to be updated and a new one for 2.14.6


OneSignalExample/ProjectSettings/ProjectSettings.asset, line 71 at r1 (raw file):

  androidUseSwappy: 1
  androidBlitType: 0
  androidResizableWindow: 0

There seems like changes that are the result of updating Unity versions. Could leave out changes to this file in future release PRs, cuts down on noisy diffs

Copy link
Contributor Author

@adamschlesinger adamschlesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @jkasten2)


OneSignalExample/Assets/OneSignal/CHANGELOG.md, line 49 at r2 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

This line needs to be updated and a new one for 2.14.6

Done.


OneSignalExample/ProjectSettings/ProjectSettings.asset, line 71 at r1 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

There seems like changes that are the result of updating Unity versions. Could leave out changes to this file in future release PRs, cuts down on noisy diffs

I ran the composer with the same version of unity I always do, not sure what happened here.

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adamschlesinger)

@adamschlesinger adamschlesinger merged commit a5a2db4 into main Dec 6, 2021
@adamschlesinger adamschlesinger deleted the release/2.14.6 branch December 6, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants