Skip to content

Conversation

@shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Feb 2, 2022

Changed

  • Added AndroidManifest with location permissions to the example app to display PromptLocation

This change is Reviewable

Copy link
Contributor

@adamschlesinger adamschlesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @adamschlesinger and @shepherd-l)

a discussion (no related file):
Let's get rid of the LauncherManifest.xml.DISABLED and its meta file and this should be good to go.


@adamschlesinger adamschlesinger requested a review from a team February 4, 2022 18:44
Copy link
Contributor

@adamschlesinger adamschlesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shepherd-l)

@shepherd-l shepherd-l merged commit b7a0b8a into develop Feb 4, 2022
@shepherd-l shepherd-l deleted the fix/displayPromptLocation branch February 4, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants