From 5a400475427a91600845af0beaadd53d1209511a Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Tue, 22 Feb 2022 14:56:22 -0600 Subject: [PATCH 01/11] Add issue template for bug reports --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 57 +++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/BUG_REPORT.yml diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml new file mode 100644 index 000000000..18b36fc26 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -0,0 +1,57 @@ +name: Bug Report +description: File a bug report +title: "[Bug]: " +labels: ["bug", "triage"] +# assignees: +# - onesignal/unity +body: + - type: markdown + attributes: + value: | + Thanks for taking the time to fill out this bug report! + - type: textarea + id: what-happened + attributes: + label: What happened? + description: Also tell us, what steps are required to reproduce. + placeholder: Tell us what's going on. + value: "Something isn't quite right!" + validations: + required: true + - type: textarea + id: what-are-expectations + attributes: + label: What did you expect to happen? + description: Also tell us, what did you expect to happen? + placeholder: Tell us what you see! + value: "A bug happened!" + validations: + required: true + - type: dropdown + id: unity-version + attributes: + label: Unity version + description: What version of Unity are you running? + options: + - Unity 2021.2.12 (latest) + - Unity 2021.x + - Unity 2020.x + - Unity 2019.x + validations: + required: true + - type: dropdown + id: platform + attributes: + label: Platform + description: Which platform are you having an issue with? + options: + - iOS + - Android + validations: + required: true + - type: textarea + id: logs + attributes: + label: Relevant log output + description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks. + render: Shell From 297599cfcc98be6081a15dbd09616cdf98b1251b Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Tue, 22 Feb 2022 14:58:08 -0600 Subject: [PATCH 02/11] Add input for accepting code of conduct --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml index 18b36fc26..138ad4536 100644 --- a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -55,3 +55,11 @@ body: label: Relevant log output description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks. render: Shell + - type: checkboxes + id: terms + attributes: + label: Code of Conduct + description: By submitting this issue, you agree to follow our [Code of Conduct](https://github.com/OneSignal/OneSignal-Unity-SDK/blob/a5a2db49604e9b6386fb46c7869db9d7f814702d/CONTRIBUTING.md) + options: + - label: I agree to follow this project's Code of Conduct + required: true From b0dd7f55f32bbef9e4c99620c129a22ad71cda97 Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Tue, 22 Feb 2022 16:27:20 -0600 Subject: [PATCH 03/11] Make platform a multi-select --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml index 138ad4536..38d017614 100644 --- a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -39,16 +39,16 @@ body: - Unity 2019.x validations: required: true - - type: dropdown + - type: checkboxes id: platform attributes: label: Platform description: Which platform are you having an issue with? options: - - iOS - - Android - validations: - required: true + - label: iOS + required: false + - label: Android + required: false - type: textarea id: logs attributes: From 365a77a919a6067ba27d522f548f300d1191e374 Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Tue, 22 Feb 2022 16:32:15 -0600 Subject: [PATCH 04/11] Make version input accept custom text --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml index 38d017614..5c968ed89 100644 --- a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -27,16 +27,13 @@ body: value: "A bug happened!" validations: required: true - - type: dropdown + - type: textarea id: unity-version attributes: label: Unity version description: What version of Unity are you running? - options: - - Unity 2021.2.12 (latest) - - Unity 2021.x - - Unity 2020.x - - Unity 2019.x + placeholder: 2021.2.x + value: 2021.2.12 (latest) validations: required: true - type: checkboxes From 0bbd4c10b21ce469b1ae144d586a135a94f40103 Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Wed, 23 Feb 2022 10:38:15 -0600 Subject: [PATCH 05/11] Make platform a multi-select dropdown --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml index 5c968ed89..623b0c4ab 100644 --- a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -36,16 +36,15 @@ body: value: 2021.2.12 (latest) validations: required: true - - type: checkboxes + - type: dropdown id: platform attributes: label: Platform description: Which platform are you having an issue with? + multiple: true options: - - label: iOS - required: false - - label: Android - required: false + - iOS + - Android - type: textarea id: logs attributes: From 39348905efb844f928631c76a60b6470ef4dc560 Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Fri, 25 Feb 2022 13:39:03 -0600 Subject: [PATCH 06/11] Split repro steps from problem description --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml index 623b0c4ab..07021c302 100644 --- a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -13,9 +13,21 @@ body: id: what-happened attributes: label: What happened? - description: Also tell us, what steps are required to reproduce. - placeholder: Tell us what's going on. - value: "Something isn't quite right!" + description: Provide a thorough description of whats going on. + placeholder: The latest version of the SDK causes my screen to go blank when I tap on the screen three times. + validations: + required: true + - type: textarea + id: reproduction-steps + attributes: + label: Steps to reproduce? + description: Provide as much detail as posible to reproduce the issue. + placeholder: | + 1. Install vX.Y.Z of dependency + 2. Launch the app on iOS device + 3. Tap the screen three times + 4. Note that the app crashes + render: Markdown validations: required: true - type: textarea From 9fb36e94fa002c2bb323411443688d070d415432 Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Fri, 25 Feb 2022 13:39:31 -0600 Subject: [PATCH 07/11] Add catch-all option for platform --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml index 07021c302..62a562149 100644 --- a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -57,6 +57,7 @@ body: options: - iOS - Android + - Other - type: textarea id: logs attributes: From 1b0341b2966ff9fa895b536064a7b623842e52b6 Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Fri, 25 Feb 2022 13:48:28 -0600 Subject: [PATCH 08/11] Use copy that makes sense --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml index 62a562149..dbf5e468d 100644 --- a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -35,8 +35,7 @@ body: attributes: label: What did you expect to happen? description: Also tell us, what did you expect to happen? - placeholder: Tell us what you see! - value: "A bug happened!" + placeholder: I expected the app to continue running no matter how many times I tap the screen. validations: required: true - type: textarea From c6439d053803c32743381616964173502748ff52 Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Mon, 28 Feb 2022 16:38:17 -0600 Subject: [PATCH 09/11] Add field to capture onsignal sdk version --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml index dbf5e468d..8e9425403 100644 --- a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -47,6 +47,15 @@ body: value: 2021.2.12 (latest) validations: required: true + - type: textarea + id: unity-sdk-version + attributes: + label: Unity SDK version + description: The version of the OneSignal Unity SDK used in your app. + placeholder: 3.0.0-beta.6 Release + value: 2.14.6 + validations: + required: true - type: dropdown id: platform attributes: From 8f59330216bf9f716f52bdb7ae16876016a3d2ff Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Mon, 28 Feb 2022 16:42:00 -0600 Subject: [PATCH 10/11] Clarify purpose of input --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml index 8e9425403..8f3d479aa 100644 --- a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -50,7 +50,7 @@ body: - type: textarea id: unity-sdk-version attributes: - label: Unity SDK version + label: OneSignal Unity SDK version description: The version of the OneSignal Unity SDK used in your app. placeholder: 3.0.0-beta.6 Release value: 2.14.6 From 0e379667afac8a77ae68ddb6b167c3a0bf86851c Mon Sep 17 00:00:00 2001 From: William Shepherd Date: Mon, 28 Feb 2022 16:43:26 -0600 Subject: [PATCH 11/11] Render the placeholder text --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml index 8f3d479aa..c5e914337 100644 --- a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -53,7 +53,6 @@ body: label: OneSignal Unity SDK version description: The version of the OneSignal Unity SDK used in your app. placeholder: 3.0.0-beta.6 Release - value: 2.14.6 validations: required: true - type: dropdown