New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project is not Carthage compatible #28

Closed
dirkoswanepoel opened this Issue May 1, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@dirkoswanepoel

dirkoswanepoel commented May 1, 2016

Making the project Carthage compatible requires a few minor changes.

https://github.com/Carthage/Carthage#supporting-carthage-for-your-framework

@TofPlay

This comment has been minimized.

TofPlay commented May 6, 2016

Hi,
For iOS and macOS projets it's will be great to make your component Carthage compatible

Take a look at these articles:

On your README.md add Carthage compatible on top and add section for the installation with Carthage.

@justjoeyuk

This comment has been minimized.

justjoeyuk commented Jul 8, 2016

Please do allow Carthage compatibility. We don't all want to be controlled by Cocoapods.

@jkasten2

This comment has been minimized.

Member

jkasten2 commented Jul 8, 2016

@justjoeyuk We now have support for Carthage in our OneSignal 2.0 Beta SDK. It only works with Xcode 8 Beta as it also includes support for iOS 10. Let us know if you have any feedback on it.

Thanks.

@justjoeyuk

This comment has been minimized.

justjoeyuk commented Jul 8, 2016

@jkasten2 Thanks a lot, great work peeps!

@JKalash

This comment has been minimized.

Contributor

JKalash commented Aug 2, 2016

@justjoeyuk Thought of letting you know that our main sdk (2.0 beta version) is available through carthage and is compatible with non-beta Xcode (7.3 and prior), as long as the iOS deployment target >= 8.0 for dynamic frameworks. Refer to: iOS SDK Installation: Carthage

Thanks!

@JKalash JKalash closed this Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment