Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up op_conf.proto #3932

Merged
merged 19 commits into from Dec 24, 2020
Merged

Tidy up op_conf.proto #3932

merged 19 commits into from Dec 24, 2020

Conversation

liujuncheng
Copy link
Collaborator

No description provided.

@liujuncheng liujuncheng added op purge purge obsolete code labels Nov 27, 2020
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot November 28, 2020 02:06
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot November 28, 2020 05:45
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot November 28, 2020 09:55
@oneflow-ci-bot oneflow-ci-bot removed their request for review November 28, 2020 15:48
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 8, 2020 08:46
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 8, 2020 09:38
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 8, 2020 11:43
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 8, 2020 12:11
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 8, 2020 13:56
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 9, 2020 02:41
Copy link
Contributor

@clackhan clackhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先不合并,有问题待讨论

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot December 24, 2020 13:41
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot December 24, 2020 16:34
@oneflow-ci-bot oneflow-ci-bot merged commit 0589d56 into master Dec 24, 2020
@oneflow-ci-bot oneflow-ci-bot deleted the dev_tidy_up_op_conf branch December 24, 2020 22:49
liujuncheng added a commit that referenced this pull request Jun 3, 2021
* Tidy up op_conf.proto

* fix

* fix

* refine

* fix

* fix

* fix typo

* fix error

* fix bug

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Co-authored-by: clackhan <han_binbin@163.com>
Former-commit-id: 0589d56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge op purge purge obsolete code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants