Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid in-source build #5182

Merged
merged 2 commits into from Jun 12, 2021
Merged

Forbid in-source build #5182

merged 2 commits into from Jun 12, 2021

Conversation

jackalcooper
Copy link
Collaborator

@jackalcooper jackalcooper commented Jun 11, 2021

因为 oneflow 的 cmake 大量使用了 glob,所以在 cmake in source build 的时候就会造成错乱,比如

In file included from [source dir]/_deps/pybind11-src/include/pybind11/pytypes.h:12:0,
                 from [source dir]/_deps/pybind11-src/include/pybind11/cast.h:13,
                 from [source dir]/_deps/pybind11-src/include/pybind11/attr.h:13,
                 from [source dir]/_deps/pybind11-src/include/pybind11/pybind11.h:45,
                 from [source dir]/oneflow/core/common/data_type.cfg.pybind.cpp:1:
[source dir]/_deps/pybind11-src/include/pybind11/detail/common.h:122:10: fatal error: Python.h: No such file or directory
 #include <Python.h>
          ^~~~~~~~~~
compilation terminated.

@oneflow-ci-bot oneflow-ci-bot merged commit f376c54 into master Jun 12, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the forbid_in_source_build branch June 12, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants