From 6cd01ab1b3812469fad671d26d86bfe004493eae Mon Sep 17 00:00:00 2001 From: jackalcooper Date: Thu, 24 Jun 2021 08:23:18 +0000 Subject: [PATCH 1/2] Don't build test by default --- CMakeLists.txt | 2 +- docker/package/manylinux/build_wheel.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 32545e05a6b..56f3540928a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -19,7 +19,7 @@ endif() option(USE_CLANG_FORMAT "" OFF) option(BUILD_RDMA "" OFF) option(BUILD_CUDA "" ON) -option(BUILD_TESTING "" ON) +option(BUILD_TESTING "" OFF) option(WITH_XLA "Option to build with XLA" OFF) option(WITH_TENSORRT "Option to build with TensorRT" OFF) option(BUILD_GIT_VERSION "" ON) diff --git a/docker/package/manylinux/build_wheel.py b/docker/package/manylinux/build_wheel.py index 96bc68bed74..dbb544d5269 100644 --- a/docker/package/manylinux/build_wheel.py +++ b/docker/package/manylinux/build_wheel.py @@ -379,6 +379,7 @@ def build(): if cuda_version in ["11.0", "11.1"]: versioned_img_tag = f"{img_prefix}:0.2" enforced_oneflow_cmake_args = "" + enforced_oneflow_cmake_args += " -DBUILD_TESTING=ON" if float(cuda_version) >= 11: assert ( "CUDNN_STATIC" not in extra_oneflow_cmake_args From ba36e1143d8331c0a73175bbd45a4de0bf9e0dc6 Mon Sep 17 00:00:00 2001 From: tsai Date: Thu, 24 Jun 2021 17:20:27 +0800 Subject: [PATCH 2/2] refine --- .github/workflows/simple.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/simple.yml b/.github/workflows/simple.yml index 60782de5059..4432cb284b2 100644 --- a/.github/workflows/simple.yml +++ b/.github/workflows/simple.yml @@ -74,6 +74,7 @@ jobs: set -x cmake_flags="" cmake_flags+=" -DBUILD_CUDA=OFF" + cmake_flags+=" -DBUILD_TESTING=ON" cmake_flags+=" -G '${{ matrix.cmake_generator }}'" cmake_flags+=" -DCMAKE_BUILD_TYPE=${{ matrix.cmake_build_type }}" cmake_flags+=" -DBUILD_SHARED_LIBS=${{ matrix.build_shared_libs }}"