From 307d8f7d2033d98ee9e2ff0aba62732b616ab4f0 Mon Sep 17 00:00:00 2001 From: PragmaTwice Date: Fri, 20 Aug 2021 13:04:21 +0800 Subject: [PATCH 1/2] check: fix clang-tidy-diff commands --- ci/check/run_clang_tidy.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/check/run_clang_tidy.py b/ci/check/run_clang_tidy.py index 9aacd318973..4679ee17850 100644 --- a/ci/check/run_clang_tidy.py +++ b/ci/check/run_clang_tidy.py @@ -91,7 +91,7 @@ def download(build_dir, dry=False): downloaded = download(args.build_dir) promises = [ run_command( - f"cd .. && git diff -U0 master | {downloaded[1]} -clang-tidy-binary {downloaded[0]} -path {args.build_dir} -quiet -j $(nproc) -p1" + f"cd .. && git diff -U0 master | {downloaded[1]} -clang-tidy-binary {downloaded[0]} -path {args.build_dir} -j $(nproc) -p1 -allow-enabling-alpha-checkers -extra-arg=-Xclang -extra-arg=-analyzer-config -extra-arg=-Xclang -extra-arg=aggressive-binary-operation-simplification=true" ) ] loop.run_until_complete(asyncio.gather(*promises)) From 22f5000b73434c31bb0a168e5ba080cd5f9e7f67 Mon Sep 17 00:00:00 2001 From: PragmaTwice Date: Fri, 20 Aug 2021 13:16:01 +0800 Subject: [PATCH 2/2] CI: fix step names --- .github/workflows/simple.yml | 2 +- .github/workflows/test.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/simple.yml b/.github/workflows/simple.yml index 369d8bf9d45..b5501d4824d 100644 --- a/.github/workflows/simple.yml +++ b/.github/workflows/simple.yml @@ -50,7 +50,7 @@ jobs: -DCMAKE_BUILD_TYPE=Release \ -DBUILD_TESTING=ON cmake --build . -j$(nproc) --target of_git_version oneflow_deps generate_functional of_cfgobj generate_py_cfg - - name: Run Maybe-related checks by clang-tidy + - name: Run clang-tidy for all translation units # use clang as compiler for correct compiler flags run: | cd build diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d259a87b709..6f28bdf03dd 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -749,7 +749,7 @@ jobs: run: | git remote add upstream https://github.com/Oneflow-Inc/oneflow git fetch upstream - - name: Run Maybe-related checks by clang-tidy + - name: Run clang-tidy for modified files # use clang as compiler for correct compiler flags run: | cd build