Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate method can accept arguments #86

Merged
merged 2 commits into from Nov 24, 2017
Merged

evaluate method can accept arguments #86

merged 2 commits into from Nov 24, 2017

Conversation

@TechQuery
Copy link
Contributor

@TechQuery TechQuery commented Nov 12, 2017

  • Add .evaluate(func, paramArray) to resolve #33
  • API documents generated by JSdoc & DocDash
@TechQuery
Copy link
Contributor Author

@TechQuery TechQuery commented Nov 22, 2017

@dotneet Is there any problem about this PR ?

@dotneet
Copy link
Collaborator

@dotneet dotneet commented Nov 24, 2017

@TechQuery Sorry for my late response.
This PR is great improvement!
Thanks!

@dotneet dotneet merged commit 0ea402d into OnetapInc:master Nov 24, 2017
@dotneet
Copy link
Collaborator

@dotneet dotneet commented Nov 24, 2017

v0.5.7 including this patch has been published now.
thanks.

@TechQuery
Copy link
Contributor Author

@TechQuery TechQuery commented Feb 28, 2018

@dotneet You can host /docs folder by GitHub Pages to show JS API document online.

@dotneet
Copy link
Collaborator

@dotneet dotneet commented Mar 1, 2018

@TechQuery Thanks! I've uploaded on GitHub Pages and wrote its link to readme.
https://onetapinc.github.io/chromy/

@TechQuery
Copy link
Contributor Author

@TechQuery TechQuery commented Mar 5, 2018

@dotneet To complete all the JSDoc comment in source code can make ReadMe.md simpler, the Home page (API document) clearer and the Source code more semantic.

And I found a little bug:

I wrote zero console.log() in this PR, but when I passed arguments to the function to be evaluated, the code generated from Babel print the source code of this function by a console.log() statement...

Temporarily, I make console.log = function () { }; and use console.info() instead in production environment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants