Skip to content

evaluate method can accept arguments - #86

Merged
dotneet merged 2 commits into
OnetapInc:masterfrom
TechQuery:master
Nov 24, 2017
Merged

dotneet merged 2 commits into
OnetapInc:masterfrom
TechQuery:master

Conversation

@TechQuery

Copy link
Copy Markdown
Contributor

@TechQuery

Copy link
Copy Markdown
Contributor Author

@dotneet Is there any problem about this PR ?

@dotneet

dotneet commented Nov 24, 2017

Copy link
Copy Markdown
Contributor

@TechQuery Sorry for my late response.
This PR is great improvement!
Thanks!

@dotneet
dotneet merged commit 0ea402d into OnetapInc:master Nov 24, 2017
@dotneet

dotneet commented Nov 24, 2017

Copy link
Copy Markdown
Contributor

v0.5.7 including this patch has been published now.
thanks.

@TechQuery

Copy link
Copy Markdown
Contributor Author

@dotneet You can host /docs folder by GitHub Pages to show JS API document online.

@dotneet

dotneet commented Mar 1, 2018

Copy link
Copy Markdown
Contributor

@TechQuery Thanks! I've uploaded on GitHub Pages and wrote its link to readme.
https://onetapinc.github.io/chromy/

@TechQuery

Copy link
Copy Markdown
Contributor Author

@dotneet To complete all the JSDoc comment in source code can make ReadMe.md simpler, the Home page (API document) clearer and the Source code more semantic.

And I found a little bug:

I wrote zero console.log() in this PR, but when I passed arguments to the function to be evaluated, the code generated from Babel print the source code of this function by a console.log() statement...

Temporarily, I make console.log = function () { }; and use console.info() instead in production environment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

evaluate not accepting args

2 participants