Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bugfixes #107

Merged
merged 3 commits into from

2 participants

@iarna
Owner

Fixing three bugs:
An invalid call to sqlmeta_exists
An invalid attempt to determine if we should drop a database
And a bogus call to schema_types

@aredridel aredridel merged commit 6b1aa8b into OnlineBuddies:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
2  Modyllic/Diff.php
@@ -46,7 +46,7 @@ private function calculate_changeset() {
}
// If our metadata table doesn't yet exist, create it
- if ( ! $this->from->sqlmeta_exists and $this->sqlmeta_exists ) {
+ if ( ! $this->from->sqlmeta_exists and $this->changeset->sqlmeta_exists ) {
$this->changeset->sqlmeta_exists = TRUE;
}
View
2  Modyllic/Generator/SQL.php
@@ -187,7 +187,7 @@ function drop( Modyllic_Schema $schema ) {
if ( isset($this->what['sqlmeta']) and $schema->sqlmeta_exists ) {
$this->drop_sqlmeta();
}
- if ( in_array('database',$what) ) {
+ if ( isset($this->what['database']) ) {
$this->drop_database( $schema );
}
$this->source = null;
View
1  scripts/sqldump
@@ -25,7 +25,6 @@ $args = Modyllic_Commandline::getArgs(array(
'long_name' => '--only',
'description' => 'comma separated list of kinds of schema objects to process: database, sqlmeta, tables, views, routines, events, triggers',
'action' => 'StoreString',
- 'default' => implode(",",Modyllic_Generator_SQL::schema_types())
) ),
'arguments' => array(
'spec' => array('multiple'=>true) )));
Something went wrong with that request. Please try again.