Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: penpal v5 #39

Merged
merged 7 commits into from May 27, 2021
Merged

feat: penpal v5 #39

merged 7 commits into from May 27, 2021

Conversation

simboonlong
Copy link
Contributor

@simboonlong simboonlong commented Jan 25, 2021

bg context

  • need to upgrade to penpal v5
  • if there is a mismatch of parent child connection versions, promise will not resolve and always be pending

attempted solution

  • try connect v5 connect first. if timeout, try v4 connect instead (for older template renderers out there)
  • promise.any v5 and v4 connections, first to resolved will connect. otherwise timeout to reject connection

Screenshot 2021-03-02 at 2 42 39 PM

@simboonlong simboonlong added the wip Work in progress label Jan 25, 2021
@simboonlong simboonlong removed the wip Work in progress label Feb 3, 2021
@simboonlong simboonlong force-pushed the feat/penpal-v5 branch 3 times, most recently from 8345671 to 7814fab Compare February 25, 2021 06:13
README.md Show resolved Hide resolved
@simboonlong simboonlong merged commit 00548cb into master May 27, 2021
@john-dot-oa
Copy link

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants