Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: Connection.create_job vs DataCube.send_job #276

Closed
soxofaan opened this issue Feb 21, 2022 · 3 comments
Closed

minor: Connection.create_job vs DataCube.send_job #276

soxofaan opened this issue Feb 21, 2022 · 3 comments
Labels
clean up good first issue low hanging fruit v1.0.0

Comments

@soxofaan
Copy link
Member

Connection.create_job vs DataCube.send_job
having differently named methods for same thing in different context is bit confusing when depending on code completion feature.

Let's settle on create_job (because that is also the verb used in openEO api)?
@m-mohr
Copy link
Member

m-mohr commented Feb 21, 2022

fwiw, that's also how it's called in all other clients, I think.

@soxofaan
Copy link
Member Author

Issue is not so minor, it would be good if it would be resolved before improving VectorCube and MlModel support (#278, #279), so that these new classes don't have to drag in deprecated usage patterns from the start

soxofaan added a commit that referenced this issue Mar 14, 2022
@soxofaan
#276 Deprecate DataCube.send_job in favor of DataCube.create_job
1726647 
Is more consistent internally and compared to other libraries/documentation
soxofaan added a commit that referenced this issue Mar 14, 2022
@soxofaan
#276 Deprecate DataCube.send_job in favor of DataCube.create_job
bb9d446 
Is more consistent internally and compared to other libraries/documentation
soxofaan added a commit that referenced this issue Mar 15, 2022
@soxofaan
#276 Deprecate DataCube.send_job in favor of DataCube.create_job
bb58ab9 
Is more consistent internally and compared to other libraries/documentation
soxofaan added a commit that referenced this issue Mar 15, 2022
@soxofaan
fixup! #276 Deprecate DataCube.send_job in favor of `DataCube.creat…
f9141c0 
…e_job`
@soxofaan soxofaan mentioned this issue Mar 15, 2022
Merged
soxofaan added a commit that referenced this issue Mar 16, 2022
@soxofaan
Issue #276 Deprecate DataCube.send_job in favor of `DataCube.create…
43eb04b 
…_job`

Is more consistent internally and compared to other libraries/documentation
soxofaan added a commit that referenced this issue Mar 17, 2022
@soxofaan
Issue #276 Deprecate DataCube.send_job in favor of `DataCube.create…
d0e4f2a 
…_job`

Is more consistent internally and compared to other libraries/documentation
@soxofaan
Copy link
Member Author

done

soxofaan added a commit to openEOPlatform/documentation that referenced this issue May 10, 2022
@soxofaan
Update send_job usage to create_job (Python)
9e65e4a 
see Open-EO/openeo-python-client#276
@soxofaan soxofaan mentioned this issue May 10, 2022
Merged
soxofaan added a commit to openEOPlatform/documentation that referenced this issue May 20, 2022
@soxofaan
Update send_job usage to create_job (Python)
fc7772e 
see Open-EO/openeo-python-client#276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clean up good first issue low hanging fruit v1.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soxofaan @m-mohr