Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occurs when trying to reload a Parameter Identification from Working Journal #157

Closed
MarKrauss opened this issue Jul 18, 2017 · 8 comments
Assignees
Milestone

Comments

@MarKrauss
Copy link
Member

Not possible to reload PI:

"Value cannot be null.
Parameter name: source"
Desktop.zip

at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source) at OSPSuite.Presentation.Mappers.ParameterIdentifications.WeightedDataRepositoryToDataTableMapper.MapFrom(WeightedObservedData weightedObservedData) at OSPSuite.Presentation.Presenters.ParameterIdentifications.WeightedDataRepositoryDataPresenter.MapDataTableFromColumns(IEnumerable1 dataColumns)
at OSPSuite.Presentation.Presenters.ObservedData.BaseDataRepositoryDataPresenter2.Rebind() at OSPSuite.Presentation.Presenters.ObservedData.BaseDataRepositoryDataPresenter2.EditObservedData(DataRepository observedData)
at OSPSuite.Presentation.Presenters.ParameterIdentifications.WeightedDataRepositoryDataPresenter.EditObservedData(WeightedObservedData weightedObservedData)
at OSPSuite.Presentation.Presenters.ParameterIdentifications.ParameterIdentificationWeightedObservedDataPresenter.Edit(WeightedObservedData weightedObservedData)
at OSPSuite.Presentation.Presenters.ParameterIdentifications.ParameterIdentificationWeightedObservedDataCollectorPresenter.edit(WeightedObservedData weightedObservedData)
at OSPSuite.Presentation.Presenters.ParameterIdentifications.ParameterIdentificationWeightedObservedDataCollectorPresenter.SelectObservedData(WeightedObservedData weightedObservedData)
at OSPSuite.Presentation.Presenters.ParameterIdentifications.ParameterIdentificationWeightedObservedDataCollectorPresenter.EditParameterIdentification(ParameterIdentification parameterIdentification)
at OSPSuite.Presentation.Presenters.ParameterIdentifications.ParameterIdentificationDataSelectionPresenter.EditParameterIdentification(ParameterIdentification parameterIdentification)
at OSPSuite.Presentation.Presenters.ParameterIdentifications.EditParameterIdentificationPresenter.<>c__DisplayClass2_0.b__0(IParameterIdentificationItemPresenter x)
at OSPSuite.Utility.Extensions.EnumerableExtensions.Each[T](IEnumerable1 list, Action1 action)
at OSPSuite.Presentation.Presenters.ParameterIdentifications.EditParameterIdentificationPresenter.InitializeSubPresentersWith(ParameterIdentification parameterIdentification)
at OSPSuite.Presentation.Presenters.EditAnalyzablePresenter4.Edit(TAnalyzable analyzable) at OSPSuite.Presentation.Presenters.SubjectPresenter3.Edit(Object objectToEdit)
at MoBi.Presentation.Tasks.SingleStartPresenterTask.StartForSubject[T](T subject)
at OSPSuite.Presentation.UICommands.EditParameterIdentificationUICommand.PerformExecute()
at OSPSuite.Presentation.UICommands.ObjectUICommand`1.Execute()
at OSPSuite.Presentation.UICommands.UICommandExtensions.ExecuteWithinExceptionHandler(IUICommand uiCommand, IEventPublisher eventPublisher, IChangePropagator changePropagator)

@msevestre
Copy link
Member

Isn't the option kind of useless? Unless you reimport in the same project, it won't really work anyways (because observed data and simulations used in PI are not saved to WJ with the PI)

@msevestre
Copy link
Member

@Yuri05 I think this should be removed (same for SA).

@msevestre
Copy link
Member

Another option would be to fail gracefully and remove everything that cannot be found.

@Yuri05
Copy link
Member

Yuri05 commented Jul 18, 2017

I think this should be removed (same for SA).

Agree.

@MarKrauss
Copy link
Member Author

I find it really important to be able to store a PI in the WJ. My proposal would be that if a PI is added to the journal the related simulation is also stored and if one reloads the PI also the simulation is reloaded such that it is possible to get all information out of the PI again.

@MarKrauss
Copy link
Member Author

I need to clarify the error a little bit. It is possible to reload. The error occurs when one double clicks on the reloaded PI afterwards

@msevestre
Copy link
Member

My proposal would be to remove this feature for now because it does not work and will not work unless we change the concept of related item in the working journal.
@MarKrauss You can create a new feature request proposing to store not only the object (PI) but also all required items (simulation, observed data etc..). Right now this is simply not possible

@msevestre
Copy link
Member

Observed data and Simulation are now exported with the Parameter identification.
When importing, it is imperative to import all in the correct order (or use the Import All button

msevestre added a commit to msevestre/MoBi that referenced this issue Feb 16, 2018
…d a Parameter Identification from Working Journal and Fixes Open-Systems-Pharmacology#242
msevestre added a commit to msevestre/MoBi that referenced this issue Feb 16, 2018
…d a Parameter Identification from Working Journal and Fixes Open-Systems-Pharmacology#242
@Yuri05 Yuri05 closed this as completed in e3d26c8 Feb 17, 2018
@msevestre msevestre added this to the Version 7.3.0 milestone Apr 23, 2018
@msevestre msevestre assigned msevestre and unassigned msevestre Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants