Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter with flag CanBeVaried set to false should be excluded from PI #170

Closed
msevestre opened this issue Sep 8, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@msevestre
Copy link
Member

commented Sep 8, 2017

This should be in implementation of Open-Systems-Pharmacology/PK-Sim#316
Possibly ReadOnly parameter as well. (A ReadOnly Parameter should never be CanBeVaried anyways)

@Yuri05

This comment has been minimized.

Copy link
Member

commented Sep 8, 2017

A ReadOnly Parameter should never be CanBeVaried anyways

There are some. E.g. Fractions Interstitial/Vascular/Intracellular.
So ReadOnly should be also taken into account

@msevestre

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2017

Fraction intestinal are can be variend? That means that the sum if for sure wrong no? I think this is a bug

@Yuri05

This comment has been minimized.

Copy link
Member

commented Sep 8, 2017

I don't think so. It should be possible to vary the fractions in Matlab/R. As one of the fractions is defined as 1-fraction1-fraction2, it will only become a problem if this fraction is varied or if fraction1+fraction2>=1. And those cases should be catched by (advanced) users in Matlab/R

@msevestre

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2017

ok but MoBi should excluded REadOnly parameters in my opinion as well as parameter that are not CanBeVaried

@StephanSchaller

This comment has been minimized.

Copy link
Member

commented Oct 10, 2017

I think this is a critical issue!

I think here, CanBeVaried in PI or Population need to be aligned.
In general only allow independent parameters to be varied (i.e. organ volume, but not BodyWeight).
And I agree with @Yuri05, that there has to be some freedom to the user (give us the credit ;-)).
This is especially the case for parameters for physiology (as often they sum up in some way as for fraction int/vas/cell).

However, there is a gap for preclinical species: we are missing physiological variability!
This means, for dose/BW applications you will always get the same Cmax within a population a populations are linearly scaled.
But here is the problem: flagging plasma or Organ Volumes for "User Defined Variability" in a population Simulation is not possible.
So either we need better animal populations, or allow user defined variability!

@UlrichSi

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

Please make sure this will not cause a similar issue as described in #208 !

@msevestre

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2018

So ReadOnly should be also taken into account

What do you mean here @Yuri05 ?

msevestre added a commit to msevestre/MoBi that referenced this issue Apr 23, 2018

@msevestre msevestre closed this in ea8c8d4 Apr 23, 2018

@msevestre msevestre added this to the Version 7.3.0 milestone Apr 23, 2018

@msevestre msevestre self-assigned this Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.