Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attachments of general files to a Journal Page #239

Closed
ju-rgen opened this issue Jul 26, 2017 · 5 comments
Closed

Allow attachments of general files to a Journal Page #239

ju-rgen opened this issue Jul 26, 2017 · 5 comments
Assignees
Milestone

Comments

@ju-rgen
Copy link
Member

@ju-rgen ju-rgen commented Jul 26, 2017

Allow attachments of other files like Excel files, pdf Reports etc. to a Journal page as Related Items.

This supports using the Working Journal as a comprehensive "single source" of model documentation.

@msevestre msevestre changed the title MBD : Allow attachments of general files to a Journal Page Allow attachments of general files to a Journal Page Jul 26, 2017
@msevestre

This comment has been minimized.

Copy link
Member

@msevestre msevestre commented Jul 28, 2017

Extension needs to be saved somewhat explicitly. Maybe some more meta data on the file such as file name, original location.
Probably update to underlying journal DB not required but this needs to be checked

@msevestre

This comment has been minimized.

Copy link
Member

@msevestre msevestre commented Jul 28, 2017

The added file will need to be loaded in memory in order to be converted to byte. Should we define an upper limit on file size?

@ju-rgen

This comment has been minimized.

Copy link
Member Author

@ju-rgen ju-rgen commented Aug 2, 2017

An upper limit of file size I find reasonable, e.g. 50 MB.
Would it create much effort, if this could be changed in the settings?
It would be good, if for file sizes larger than 5MB a confirmation dialogue opens with information about the size of the file.

@tobiasK2001

This comment has been minimized.

Copy link
Member

@tobiasK2001 tobiasK2001 commented Aug 2, 2017

hmm. normally my excel files are about 50 KB. However in some extreme cases they are 30 MB. I also have some CSV with POP-sim results with about 109 MB. PDF-reports / Paper are normally below 5 MB.
So I would suggest an upper limit of 150 MB and ask the user for files larger 5 MB if he really wants to keep it that way ;-)

@msevestre msevestre self-assigned this Feb 14, 2018
@msevestre

This comment has been minimized.

Copy link
Member

@msevestre msevestre commented Feb 15, 2018

Upper file limit will be set to 50MB . After various tests, I managed to crash the app with bigger files

@msevestre msevestre closed this in c335cc3 Feb 15, 2018
msevestre added a commit that referenced this issue Feb 15, 2018
@Yuri05 please review when you have time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.