Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Manually provided location properties getting ignored #471

Merged
merged 1 commit into from Mar 6, 2020
Merged

Bugfix: Manually provided location properties getting ignored #471

merged 1 commit into from Mar 6, 2020

Conversation

Maaiins
Copy link
Contributor

@Maaiins Maaiins commented Mar 2, 2020

Manually set location properties like the following getting ignored.

$owa = new owa_php();
$owa->setProperty('country', 'Germany');

Because owa_trackingEventHelpers::resolveCountry returns null, when the value is already set.
So owa_eventDispatch::filter assigns null to the value variable and returns null.

Which result in owa_trackingEventHelpers::setTrackerProperties overriding the already set property with null, in line 138.

@padams padams added bug Bug in code confirmed and identified. Core Development Changes to framework or base module. hasfix a fix has been applied to master. labels Mar 6, 2020
@padams padams merged commit 4cc54fe into Open-Web-Analytics:master Mar 6, 2020
@Maaiins Maaiins deleted the fix_manual_set_tracking_options branch March 6, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in code confirmed and identified. Core Development Changes to framework or base module. hasfix a fix has been applied to master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants