New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Function Support, Extended Documentation and UTF8 Settings #1

Merged
merged 12 commits into from Sep 5, 2014

Conversation

Projects
None yet
2 participants
@brookinsconsulting
Copy link
Contributor

brookinsconsulting commented May 20, 2012

Hello Open-Wide / eZ Community!

Today we present for your review and acceptance:

  • Whitelist (eZ Publish INI Settings) PHP Function Support within eZ Publish Templates (eZ 4.x Only)
  • Extensive GitHub Markdown based extension documentation
  • UTF8 Encoded Settings

Please accept this pull request into your master repository branch of OWSimpleOperator and help other users make use of Whitelisted PHP Functions within custom eZ Publish templates.

Cheers,
Brookins Consulting

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented May 31, 2012

Since this extension pull request was not understood, commented on, accepted or welcomed it has now been closed.

@Dryobs

This comment has been minimized.

Copy link
Contributor

Dryobs commented Oct 19, 2012

Thanks for your quality contribution.

Please apologize our lack of answer. We will welcome your gift, as we must to do it.

@ghost ghost assigned Dryobs Oct 19, 2012

@Dryobs

This comment has been minimized.

Copy link
Contributor

Dryobs commented Oct 19, 2012

Hi,
How exactly works phpfunction operator ?

I try this following :
{def $output = str_replace('tototatatiti', 'tata', 'titi')}
and
{def $output = 'tototatatiti'|str_replace('tata', 'titi')}

But I get this error message :
array_values() expects exactly 1 parameter, 2 given in /var/www/ez/extension/owsimpleoperator/autoloads/owsimpleoperator.php on line 317

Thanks in advance !

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented Apr 21, 2013

Hello Sboye,

Thank you very much for your replies.

Regarding the error you get.

It has been some time since we used this improved extension so our answers may be dusty.

We seem to remember getting the error message you shared when the changes made to "autoloads/eztemplateautoload.php" were not made or were not exactly as provided in the following commit...

brookinsconsulting@028a556

We suggest comparing your local changes (diff/run the code) to the extension OWSimpleOperator with our own github copy: https://github.com/brookinsconsulting/OWSimpleOperator which did not have the error you mention.

The solution to that error you share was a very specific one that required the above autoload file to be re-written to check for PHP functions and allow them to be used even if they use more than one parameter.

Best wishes

Cheers,
Brookins Consulting

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented Jun 6, 2013

Hello Open-Wide,

We wanted to inquire on the status of our pull request. We would be happy to help in any way we can get our changes into the extension in question.

Cheers,
Brookins Consulting

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented Sep 5, 2014

Hello @sboye / Open-Wide

We offer our most sincere apologies for our previous weak replies. We truly were not having the problems you were reporting so it made testing and solving the problems nearly impossible at the time.

Tonight I set it upon myself to once and for all solve the problems you reported and once again prepare this pull request for another review. In our commits for tonight we have done two things.

First we have solved the errors you were reporting. We have tested with both single parameter php functions and multi-parameter php functions. I am very certain that the previous template operator parameters conversion to php function parameters errors are now finally solved.

Second we have merged in the more recent changes made to the master branch into the php_function_support feature branch solving the merge conflict issue with this pull request. Now this pull request can be automatically merged normally without conflicts.

We realize that a lot of time has passed since we first submitted this pull request.
We ask now for another chance at a round of review and testing of our pull request changes.

Please let us know what you think! Thanking you in advance for your continued support!

Cheers,
Brookins Consulting
Skype: brookinsconsulting
Email: info at brookinsconsulting dot com

@Dryobs

This comment has been minimized.

Copy link
Contributor

Dryobs commented Sep 5, 2014

Hello @brookinsconsulting !

Thanks a lot for your contribution and your last fix. This pull-request will be merged.

Cheers

Dryobs pushed a commit that referenced this pull request Sep 5, 2014

Simon Boyer
Merge pull request #1 from brookinsconsulting/php_function_support
PHP Function Support, Extended Documentation and UTF8 Settings

@Dryobs Dryobs merged commit 21d3841 into Open-Wide:master Sep 5, 2014

@brookinsconsulting brookinsconsulting deleted the brookinsconsulting:php_function_support branch Sep 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment