New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Ini settings based custom template operator configuration #2

Merged
merged 1 commit into from Sep 5, 2014

Conversation

Projects
None yet
2 participants
@brookinsconsulting
Copy link
Contributor

brookinsconsulting commented Sep 5, 2014

Hello,

One aspect to this extension that has always bothered our developers is the need to edit or customize the extension/OWSimpleOperator/autoloads/eztemplateautoload.php file to add custom template operator functions. (As instructed in the documentation)

By comparison in our other custom template operator extension, wrapoperator we do not have to customize any core extension php files to add user defined template operator functions, instead we have settings based configuration for this need: https://github.com/brookinsconsulting/wrapoperator/blob/master/settings/wrapoperator.ini#L11

We have taken the time to introduce ini settings based custom template operator configuration into the OWSimpleOperator extension.

With our changes in place you can define custom template operator functions via ini settings. This means you can leave the core php files of the OWSimpleOperator alone / stock / as default.

To add a custom template operator function just edit the owsimpleoperator.ini.append.php template override say in settings/override/owsimpleoperator.ini.append.php file and add the template operator file path (ezp4 compat), template operator class name and template operator class method name configuration settings you desire. Then clear ini caches and you can use your custom template operator right away! No more hacking of core extension php files like extension/OWSimpleOperator/autoloads/eztemplateautoload.php which can't be overriden with class based overrides.

Please let us know what you think of this new feature! We think it's great for all users of this extension! Especially in multi site configurations.

Cheers,
Brookins Consulting

@Dryobs

This comment has been minimized.

Copy link

Dryobs commented on bcd0df9 Sep 5, 2014

Hello @brookinsconsulting,
Thanks for this grate contribution.
We can merge it.

Cheers

@Dryobs Dryobs merged commit bcd0df9 into Open-Wide:master Sep 5, 2014

Dryobs pushed a commit that referenced this pull request Sep 5, 2014

Dryobs pushed a commit that referenced this pull request Sep 5, 2014

@Dryobs

This comment has been minimized.

Copy link
Contributor

Dryobs commented Sep 5, 2014

This feature is very usefull, thanks !
I merged this pull-request with previous types of operator declarations.

@brookinsconsulting brookinsconsulting deleted the brookinsconsulting:settings_based_class_functions branch Sep 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment