Conversation
Contributor
|
Thanks, it's a great improvement. Cheers, |
rey0bs
pushed a commit
that referenced
this pull request
Sep 8, 2014
…mplateautoload Implemented: Single, Global eztemplateautoload.php Include
brookinsconsulting
deleted the
single_instance_of_eztemplateautoload
branch
September 11, 2014 11:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the acceptance of our previous pull request #2 it no longer makes sense to force developers and users make static instances of eztemplateautoload.php operator autoload files since now the extension's provided autoload/eztemplateautoload.php file is now both dynamic and ini settings based.
Once merged these changes allow for a single global ezetemplateautoload.php file (already in place in the extension's autoload directory.
To create a custom operator you no longer need a custom class file + eztemplateautoload.php file + ini settings override; you only need your custom class file + ini settings override.
This is a big improvement to the current state of affairs. We hope you'll agree and accept this pull request.
These changes make using the OWSimpleOperator extension to create a custom operator class stored in a separate extension's class directory and activated via global ini settings override both painless and eZ to do!
Please let us know what you think!
Cheers,
Brookins Consulting