New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Added settings and code to provide for ini setting to disable debug output #5

Merged
merged 1 commit into from Sep 29, 2014

Conversation

Projects
None yet
2 participants
@brookinsconsulting
Copy link
Contributor

brookinsconsulting commented Sep 28, 2014

Hello Open-Wide,

We have been working with your OWSimpleOperator extension more and more and have found another issue with the code which we wish to improve.

The problem

We have found situations where we no longer wished to see the function calls and results from our template operator calls using OWSimpleOperator.

After some amount of time we finally decided to find out why there seemed to be no way to configure this behavior. We found that the class included a public variable of the OWSimpleOperator class which controlled this behavior.

The solution

We extended this behavior by adding a class constructor method which enables or disables automatic debug output based on simple to manage ini settings.

We did not change the behavior of the code only it's configurability. Instead of class property manipulation we now provide ini settings based manipulation.

Backwards compatibility

The automatic debug output is still enabled by default just like before our pull request.

This was done this way to maintain backwards compatibility for sites which already expect this feature to be enabled by default.

For sites which which to disable this output they now can make an ini setting file override and disable the automatic debug output using the [OWSimpleOperatorSettings] DebugOutput=disabled ini setting.

Closing

This is a big improvement to the current state of affairs. We hope you'll agree and accept this pull request.

These changes make using the OWSimpleOperator extension to use custom operators which do not cause debug output to become cluttered with operator calls and results debug output when you don't want them to do so.

Please let us know what you think of this new feature! We think it's great for all users of this extension! Especially in multi site configurations.

Cheers,
Brookins Consulting

Dryobs pushed a commit that referenced this pull request Sep 29, 2014

Simon Boyer
Merge pull request #5 from brookinsconsulting/debug-output-optional
Implemented: Added settings and code to provide for ini setting to disable debug output

@Dryobs Dryobs merged commit 55f6d86 into Open-Wide:master Sep 29, 2014

@Dryobs

This comment has been minimized.

Copy link
Contributor

Dryobs commented Sep 29, 2014

Hi,
Thanks for your contribution and your detailed explanations.
This improvement has been merged.

Cheers,
Simon Boyer

@brookinsconsulting brookinsconsulting deleted the brookinsconsulting:debug-output-optional branch Sep 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment