Implemented: Added settings and code to provide for ini setting to disable debug output #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sable debug output
rey0bs
pushed a commit
that referenced
this pull request
Sep 29, 2014
Implemented: Added settings and code to provide for ini setting to disable debug output
|
Hi, Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Open-Wide,
We have been working with your OWSimpleOperator extension more and more and have found another issue with the code which we wish to improve.
The problem
We have found situations where we no longer wished to see the function calls and results from our template operator calls using OWSimpleOperator.
After some amount of time we finally decided to find out why there seemed to be no way to configure this behavior. We found that the class included a public variable of the OWSimpleOperator class which controlled this behavior.
The solution
We extended this behavior by adding a class constructor method which enables or disables automatic debug output based on simple to manage ini settings.
We did not change the behavior of the code only it's configurability. Instead of class property manipulation we now provide ini settings based manipulation.
Backwards compatibility
The automatic debug output is still enabled by default just like before our pull request.
This was done this way to maintain backwards compatibility for sites which already expect this feature to be enabled by default.
For sites which which to disable this output they now can make an ini setting file override and disable the automatic debug output using the [OWSimpleOperatorSettings] DebugOutput=disabled ini setting.
Closing
This is a big improvement to the current state of affairs. We hope you'll agree and accept this pull request.
These changes make using the OWSimpleOperator extension to use custom operators which do not cause debug output to become cluttered with operator calls and results debug output when you don't want them to do so.
Please let us know what you think of this new feature! We think it's great for all users of this extension! Especially in multi site configurations.
Cheers,
Brookins Consulting